Eng/pr swift frontend tweaks for caching #65925
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cachemeifyoucan
requested review from
akyrtzi,
nkcsgexi,
benlangmuir,
artemcm and
jansvoboda11
cachemeifyoucan
requested review from
zoecarver,
hyp and
egorzhdan
as code owners
|
@swift-ci please smoke test |
|
@swift-ci please test windows platform |
When pch are explicitly created, there is no need to cached produced pch in memory since pch is only going to be consumed by a later process.
Don't add cxx shim when c++ interop is not used. This is to cut down the unnecessary dependencies that are not seen by the dependency scanner.
When creating ClangImporter directly from cc1 args, there is no need for clang path, and it might even be mistaken as an input path. Don't use clang executable path in the arguments when creating from cc1 commands.
When using explicit module build, there is no need to check top level module map to see if the module exists or not, since dependency scanning already pulled in all needed modules. Furthermore, when using clang include tree, the module maps are not available through FS for this search. Just directly try to load modules when using explicit module build.
cachemeifyoucan
force-pushed
the
eng/PR-swift-frontend-tweaks-for-caching
branch
from
d8efab5 to
f4569a6
Compare
|
@swift-ci please smoke test |
artemcm
approved these changes
May 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains some tweaks to swift-frontend to smooth out some edges in order to land caching PRs.