Skip to content

[5.9][CodeComplete] Offer completions after ~ in an inheritance clause #65933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

ahoppen
Copy link
Member

@ahoppen ahoppen commented May 16, 2023

We should only be suggesting `Copyable` after `~` in an inheritance clause, in accordance with [SE-0390](https://github.com/apple/swift-evolution/blob/main/proposals/0390-noncopyable-structs-and-enums.md)

rdar://109063223
@ahoppen ahoppen requested a review from a team as a code owner May 16, 2023 00:05
@ahoppen
Copy link
Member Author

ahoppen commented May 16, 2023

@swift-ci Please test

@ahoppen ahoppen added 🍒 release cherry pick Flag: Release branch cherry picks swift 5.9 labels May 16, 2023
@ahoppen ahoppen changed the title [CodeComplete] Offer completions after ~ in an inheritance clause [5.9][CodeComplete] Offer completions after ~ in an inheritance clause May 16, 2023
Copy link
Member

@DougGregor DougGregor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but someday I want ~Sendable, too

@ahoppen ahoppen merged commit 3dfc4a5 into swiftlang:release/5.9 May 26, 2023
@ahoppen ahoppen deleted the ahoppen/5.9/complete-constraint-type branch May 26, 2023 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🍒 release cherry pick Flag: Release branch cherry picks swift 5.9
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants