[Macros] Fix lookup of macro-produced variables #65939
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test |
DougGregor
reviewed
May 16, 2023
|
@swift-ci please smoke test |
|
@swift-ci please smoke test macos |
Calling `getInnermostDeclContext()->getParentSourceFile()` on a macro-produced decl does not seem to be a reliable way to obtain the macro expansion source file, because `PatternBindingDecl` is not a `DeclContext` and `getInnermostDeclContext()` falls back outside the macro expansion file. This patch switches to using `getSourceFileContainingLocation` when possible. Resolves rdar://109376568.
|
@swift-ci please smoke test |
|
@swift-ci please smoke test |
DougGregor
approved these changes
May 18, 2023
rxwei
added a commit
to rxwei/swift
that referenced
this pull request
May 18, 2023
Calling `getInnermostDeclContext()->getParentSourceFile()` on a macro-produced decl does not seem to be a reliable way to obtain the macro expansion source file, because `PatternBindingDecl` is not a `DeclContext` and `getInnermostDeclContext()` falls back outside the macro expansion file. This patch switches to using `getSourceFileContainingLocation` when possible. Resolves rdar://109376568.
rxwei
added a commit
to rxwei/swift
that referenced
this pull request
May 18, 2023
Calling `getInnermostDeclContext()->getParentSourceFile()` on a macro-produced decl does not seem to be a reliable way to obtain the macro expansion source file, because `PatternBindingDecl` is not a `DeclContext` and `getInnermostDeclContext()` falls back outside the macro expansion file. This patch switches to using `getSourceFileContainingLocation` when possible. Resolves rdar://109376568.
meg-gupta
pushed a commit
to meg-gupta/swift
that referenced
this pull request
May 22, 2023
Calling `getInnermostDeclContext()->getParentSourceFile()` on a macro-produced decl does not seem to be a reliable way to obtain the macro expansion source file, because `PatternBindingDecl` is not a `DeclContext` and `getInnermostDeclContext()` falls back outside the macro expansion file. This patch switches to using `getSourceFileContainingLocation` when possible. Resolves rdar://109376568.
NuriAmari
pushed a commit
to NuriAmari/swift
that referenced
this pull request
May 28, 2023
Calling `getInnermostDeclContext()->getParentSourceFile()` on a macro-produced decl does not seem to be a reliable way to obtain the macro expansion source file, because `PatternBindingDecl` is not a `DeclContext` and `getInnermostDeclContext()` falls back outside the macro expansion file. This patch switches to using `getSourceFileContainingLocation` when possible. Resolves rdar://109376568.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling
getInnermostDeclContext()->getParentSourceFile()on a macro-produced decl does not seem to be a reliable way to obtain the macro expansion source file, becausePatternBindingDeclis not aDeclContextandgetInnermostDeclContext()falls back outside the macro expansion file. This patch switches to usinggetSourceFileContainingLocationinstead.Resolves rdar://109376568.