[5.9] IRGen: fix async vtable stubs #65947
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For deleted async vtable methods we need to create a async function pointer. Fixes a missing-symbol linker error rdar://108924001
|
@swift-ci test |
tbkka
approved these changes
May 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: For deleted async vtable methods we need to create a async function pointer. If the optimizer removes a private class method, its symbol must still be generated in the binary, because derived classes in other translation units must be able to reference the symbol in the vtable of the derived class.
This all worked with regular methods, but we didn't do that for async methods.
It fixes a missing-symbol linker error.
Risk: Low. It only affects private async class methods which are removed by the optimizer. Generated code, which is actually executed, is not affected. The only change is to create the missing symbol in the binary.
Reviewed by: @nate-chandler
Testing: CI testing via lit tests
Original PR: #65940
Radar: rdar://108924001