Skip to content

[Observation] Member properties that have visibility attributes shoul… #66002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

phausler
Copy link
Contributor

Cherry-pick of #65812

Variables declared with visibility and other modifiers ended up incorrectly synthesizing the storage without a trailing space after the private modifier.

public weak var obj: AnyObject? = nil

would incorrectly generate storage as:

privateweak var _obj: AnyObject? = nil

This change corrects that by adding a trailing trivia of a space on the private modifier.

Resolves: rdar://109121917

@phausler phausler requested a review from a team as a code owner May 18, 2023 19:57
@phausler
Copy link
Contributor Author

@swift-ci please test

Copy link
Member

@natecook1000 natecook1000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@phausler phausler merged commit f60d855 into swiftlang:release/5.9 May 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants