Skip to content

[stdlib] Implement SE-147: Move initialize(from:) from Pointer to BufferPointer #6601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jan 7, 2017
Merged

[stdlib] Implement SE-147: Move initialize(from:) from Pointer to BufferPointer #6601

merged 6 commits into from
Jan 7, 2017

Conversation

airspeedswift
Copy link
Member

@airspeedswift airspeedswift commented Jan 5, 2017 •
edited
Loading

This PR implements SE-147

Specifically it:

  • deprecates initialize(from:) in UnsafeMutable{Raw}BufferPointer
  • introduces a safer replacement in UnsafeMutable{Raw}BufferPointer
  • alters any uses of the old one in the std lib to use the new one
  • eliminates the version of Array.append that takes a collection as no-longer necessary
  • moves Array's += operator up to RangeReplaceableCollection

@airspeedswift
Copy link
Member Author

@swift-ci Please test

@airspeedswift
Copy link
Member Author

@swift-ci Please benchmark

@swift-ci
Copy link
Contributor

swift-ci commented Jan 5, 2017

Build failed
Jenkins build - Swift Test Linux Platform
Git Commit - ca6353d
Test requested by - @airspeedswift

@swift-ci
Copy link
Contributor

swift-ci commented Jan 5, 2017

Build failed
Jenkins build - Swift Test OS X Platform
Git Commit - ca6353d
Test requested by - @airspeedswift

@airspeedswift
Copy link
Member Author

@swift-ci Please test OS X platform

@airspeedswift
Copy link
Member Author

Uh-oh. Looks like Data in swift-corelibs-foundation is using _copyContents.

https://github.com/apple/swift-corelibs-foundation/blob/master/Foundation/Data.swift#L1439

@swift-ci
Copy link
Contributor

swift-ci commented Jan 5, 2017

Build comment file:

Optimized (O)

Regression (4)
TEST OLD_MIN NEW_MIN DELTA (%) SPEEDUP
ArrayAppendSequence 1061 1392 +31.2% 0.76x
ArrayAppendRepeatCol 642 759 +18.2% 0.85x
ArrayAppendLazyMap 840 915 +8.9% 0.92x
PopFrontArray 1122 1202 +7.1% 0.93x(?)
Improvement (6)
TEST OLD_MIN NEW_MIN DELTA (%) SPEEDUP
StringHasPrefix 680 608 -10.6% 1.12x
StringHasSuffix 796 696 -12.6% 1.14x
ArrayAppendToFromGeneric 1074 599 -44.2% 1.79x
ArrayAppendFromGeneric 1073 599 -44.2% 1.79x
ArrayAppendToGeneric 1072 599 -44.1% 1.79x
ByteSwap 1 0 -99.9% 1001.00x
No Changes (145)
TEST OLD_MIN NEW_MIN DELTA (%) SPEEDUP
StaticArray 746 716 -4.0% 1.04x(?)
Hanoi 3603 3458 -4.0% 1.04x
Phonebook 7851 7517 -4.2% 1.04x
SortSortedStrings 4917 4796 -2.5% 1.03x
Calculator 35 34 -2.9% 1.03x
SortStrings 1875 1846 -1.6% 1.02x
ObjectiveCBridgeFromNSArrayAnyObjectForced 6559 6457 -1.6% 1.02x(?)
ObjectiveCBridgeStubToNSDate 13723 13415 -2.2% 1.02x(?)
ObjectiveCBridgeStubFromNSString 797 779 -2.3% 1.02x
SetIntersect 371 364 -1.9% 1.02x(?)
ObjectiveCBridgeFromNSDictionaryAnyObject 165613 164638 -0.6% 1.01x(?)
ObjectiveCBridgeFromNSArrayAnyObjectToString 97505 96563 -1.0% 1.01x(?)
ObjectiveCBridgeFromNSStringForced 2707 2690 -0.6% 1.01x(?)
ReversedDictionary 92 91 -1.1% 1.01x(?)
Join 475 468 -1.5% 1.01x
ObjectAllocation 154 153 -0.7% 1.01x(?)
HashTest 1746 1733 -0.7% 1.01x(?)
Dictionary2 2037 2022 -0.7% 1.01x(?)
ObserverUnappliedMethod 2350 2316 -1.4% 1.01x(?)
ObjectiveCBridgeStubToNSDateRef 3271 3251 -0.6% 1.01x(?)
ObjectiveCBridgeStubURLAppendPath 245302 242782 -1.0% 1.01x(?)
SortStringsUnicode 8402 8318 -1.0% 1.01x(?)
Dictionary 720 714 -0.8% 1.01x
SetExclusiveOr 2576 2541 -1.4% 1.01x(?)
ObjectiveCBridgeFromNSSetAnyObjectForced 4775 4729 -1.0% 1.01x(?)
SetUnion 2457 2426 -1.3% 1.01x(?)
Chars 622 618 -0.6% 1.01x
ObjectiveCBridgeToNSString 1072 1070 -0.2% 1.00x(?)
DictionarySwapOfObjects 6293 6303 +0.2% 1.00x(?)
RecursiveOwnedParameter 1943 1935 -0.4% 1.00x
ObjectiveCBridgeStubToNSString 1277 1273 -0.3% 1.00x(?)
ClassArrayGetter 12 12 +0.0% 1.00x
Array2D 2034 2026 -0.4% 1.00x(?)
Histogram 282 283 +0.3% 1.00x(?)
DictionaryBridge 3405 3410 +0.1% 1.00x(?)
ObjectiveCBridgeStubFromNSDateRef 3959 3950 -0.2% 1.00x(?)
ArrayOfGenericPOD 220 220 +0.0% 1.00x
StringWithCString 211989 211802 -0.1% 1.00x(?)
Prims 729 731 +0.3% 1.00x(?)
SortLettersInPlace 965 969 +0.4% 1.00x(?)
DictionarySwap 424 424 +0.0% 1.00x
Dictionary3OfObjects 871 871 +0.0% 1.00x
ArrayAppendGenericStructs 1235 1241 +0.5% 1.00x(?)
SuperChars 210815 211765 +0.5% 1.00x(?)
XorLoop 380 380 +0.0% 1.00x
ArrayAppendReserved 536 536 +0.0% 1.00x
StringInterpolation 10974 11024 +0.5% 1.00x(?)
ObserverClosure 1947 1940 -0.4% 1.00x(?)
Integrate 238 238 +0.0% 1.00x
ArrayAppendStrings 12131 12130 -0.0% 1.00x(?)
ObjectiveCBridgeStubFromNSStringRef 125 125 +0.0% 1.00x
TypeFlood 0 0 +0.0% 1.00x
ProtocolDispatch 3040 3040 +0.0% 1.00x
ObjectiveCBridgeFromNSSetAnyObject 80671 80559 -0.1% 1.00x(?)
ArrayLiteral 1180 1178 -0.2% 1.00x(?)
ArrayPlusEqualArrayOfInt 599 599 +0.0% 1.00x
Dictionary3 523 521 -0.4% 1.00x(?)
StrComplexWalk 2916 2918 +0.1% 1.00x(?)
SetIntersect_OfObjects 1502 1501 -0.1% 1.00x(?)
ErrorHandling 2970 2975 +0.2% 1.00x(?)
ArrayOfRef 3541 3551 +0.3% 1.00x(?)
ObjectiveCBridgeToNSSet 38171 38299 +0.3% 1.00x(?)
ArrayAppendOptionals 1234 1231 -0.2% 1.00x(?)
NSError 329 330 +0.3% 1.00x(?)
DictionaryOfObjects 2286 2279 -0.3% 1.00x(?)
StringEqualPointerComparison 7301 7301 +0.0% 1.00x
CaptureProp 4564 4563 -0.0% 1.00x(?)
PolymorphicCalls 22 22 +0.0% 1.00x
RC4 165 165 +0.0% 1.00x
ObjectiveCBridgeStubToNSStringRef 116 116 +0.0% 1.00x
MapReduce 342 343 +0.3% 1.00x(?)
AngryPhonebook 2835 2843 +0.3% 1.00x(?)
IterateData 2516 2524 +0.3% 1.00x(?)
DictionaryLiteral 1267 1266 -0.1% 1.00x(?)
UTF8Decode 288 288 +0.0% 1.00x
ObjectiveCBridgeFromNSDictionaryAnyObjectToStringForced 107563 108025 +0.4% 1.00x(?)
SetIsSubsetOf 250 250 +0.0% 1.00x
NopDeinit 21445 21440 -0.0% 1.00x(?)
ObjectiveCBridgeStubToArrayOfNSString 29436 29418 -0.1% 1.00x(?)
ObjectiveCBridgeFromNSArrayAnyObject 74255 74523 +0.4% 1.00x(?)
ObjectiveCBridgeStubDataAppend 3444 3439 -0.1% 1.00x(?)
ObjectiveCBridgeFromNSSetAnyObjectToString 116217 116606 +0.3% 1.00x(?)
ObjectiveCBridgeStubNSDateRefAccess 337 338 +0.3% 1.00x(?)
StrToInt 5319 5341 +0.4% 1.00x(?)
ArrayInClass 63 63 +0.0% 1.00x
ObjectiveCBridgeStubDateAccess 182 182 +0.0% 1.00x
Sim2DArray 277 277 +0.0% 1.00x
ObjectiveCBridgeStubDateMutation 273 273 +0.0% 1.00x
MonteCarloPi 44973 45136 +0.4% 1.00x(?)
MonteCarloE 10546 10568 +0.2% 1.00x(?)
Walsh 312 313 +0.3% 1.00x(?)
SetIsSubsetOf_OfObjects 306 306 +0.0% 1.00x
ArrayAppend 774 774 +0.0% 1.00x
DictionaryRemove 2360 2353 -0.3% 1.00x(?)
ObjectiveCBridgeFromNSSetAnyObjectToStringForced 81035 81325 +0.4% 1.00x(?)
RGBHistogramOfObjects 21518 21540 +0.1% 1.00x(?)
RGBHistogram 2254 2258 +0.2% 1.00x(?)
ArrayAppendArrayOfInt 599 599 +0.0% 1.00x
ArrayOfPOD 182 182 +0.0% 1.00x
ReversedArray 49 49 +0.0% 1.00x
StringBuilder 1314 1319 +0.4% 1.00x(?)
ObserverForwarderStruct 878 876 -0.2% 1.00x(?)
DeadArray 185 185 +0.0% 1.00x
ObjectiveCBridgeStubNSDataAppend 2432 2431 -0.0% 1.00x(?)
BitCount 1 1 +0.0% 1.00x
AnyHashableWithAClass 65549 65613 +0.1% 1.00x(?)
SevenBoom 1391 1389 -0.1% 1.00x(?)
ArrayValueProp 6 6 +0.0% 1.00x
GlobalClass 0 0 +0.0% 1.00x
Memset 235 235 +0.0% 1.00x
Dictionary2OfObjects 3434 3423 -0.3% 1.00x(?)
ArrayValueProp4 6 6 +0.0% 1.00x
ArrayValueProp2 6 6 +0.0% 1.00x
ArrayValueProp3 6 6 +0.0% 1.00x
ObserverPartiallyAppliedMethod 3382 3387 +0.1% 1.00x(?)
ArraySubscript 1425 1436 +0.8% 0.99x(?)
StackPromo 21494 21624 +0.6% 0.99x(?)
ObjectiveCBridgeFromNSDictionaryAnyObjectForced 5470 5513 +0.8% 0.99x(?)
RangeAssignment 279 281 +0.7% 0.99x(?)
ReversedBidirectonal 44861 45177 +0.7% 0.99x(?)
ObjectiveCBridgeStubURLAppendPathRef 244079 246838 +1.1% 0.99x(?)
PopFrontArrayGeneric 1117 1127 +0.9% 0.99x(?)
PopFrontUnsafePointer 9067 9118 +0.6% 0.99x(?)
154 2984313 2999524 +0.5% 0.99x
NSDictionaryCastToSwift 4960 5002 +0.8% 0.99x(?)
ArrayOfGenericRef 3636 3674 +1.1% 0.99x(?)
ObjectiveCBridgeToNSDictionary 60795 61304 +0.8% 0.99x(?)
StringHasSuffixUnicode 62478 63061 +0.9% 0.99x
StringHasPrefixUnicode 13785 13948 +1.2% 0.99x(?)
LinkedList 7216 7255 +0.5% 0.99x(?)
ObjectiveCBridgeFromNSArrayAnyObjectToStringForced 89777 90611 +0.9% 0.99x(?)
StringWalk 5855 5897 +0.7% 0.99x(?)
ObjectiveCBridgeStubFromArrayOfNSString 57554 58000 +0.8% 0.99x(?)
TwoSum 1312 1320 +0.6% 0.99x(?)
ProtocolDispatch2 157 160 +1.9% 0.98x
ObjectiveCBridgeToNSArray 29997 30633 +2.1% 0.98x(?)
OpenClose 58 59 +1.7% 0.98x
DictionaryRemoveOfObjects 19269 19576 +1.6% 0.98x(?)
ObjectiveCBridgeFromNSString 1799 1840 +2.3% 0.98x(?)
SetExclusiveOr_OfObjects 7371 7497 +1.7% 0.98x
SetUnion_OfObjects 6200 6331 +2.1% 0.98x(?)
ObjectiveCBridgeFromNSDictionaryAnyObjectToString 173348 178290 +2.9% 0.97x(?)
NSStringConversion 809 830 +2.6% 0.97x
ObjectiveCBridgeStubNSDateMutationRef 11749 12151 +3.4% 0.97x(?)
ObjectiveCBridgeStubFromNSDate 3803 3928 +3.3% 0.97x(?)
**Unoptimized (Onone)**
Regression (5)
TEST OLD_MIN NEW_MIN DELTA (%) SPEEDUP
ObjectiveCBridgeStubDateMutation 456 517 +13.4% 0.88x
StringHasSuffix 1652 1862 +12.7% 0.89x
ArrayPlusEqualArrayOfInt 643 714 +11.0% 0.90x
ArrayAppendArrayOfInt 642 714 +11.2% 0.90x
StringHasPrefixUnicode 14784 15777 +6.7% 0.94x
Improvement (10)
TEST OLD_MIN NEW_MIN DELTA (%) SPEEDUP
NopDeinit 47606 45019 -5.4% 1.06x
Calculator 1061 994 -6.3% 1.07x
StringWalk 22388 20928 -6.5% 1.07x
ArrayOfGenericPOD 3422 3071 -10.3% 1.11x
154 6565664 5871064 -10.6% 1.12x
ArrayAppendSequence 99634 84450 -15.2% 1.18x
ProtocolDispatch 6453 5475 -15.2% 1.18x
ArrayAppendToGeneric 225476 718 -99.7% 314.03x
ArrayAppendFromGeneric 225578 717 -99.7% 314.61x
ArrayAppendToFromGeneric 225584 716 -99.7% 315.06x
No Changes (140)
TEST OLD_MIN NEW_MIN DELTA (%) SPEEDUP
Phonebook 21777 21120 -3.0% 1.03x
Chars 6656 6432 -3.4% 1.03x
DictionaryBridge 3532 3461 -2.0% 1.02x(?)
StringHasPrefix 1667 1637 -1.8% 1.02x(?)
ObjectiveCBridgeStubFromNSString 826 811 -1.8% 1.02x
StringEqualPointerComparison 9987 9810 -1.8% 1.02x
ObjectiveCBridgeStubFromNSDateRef 4156 4077 -1.9% 1.02x
BitCount 98 96 -2.0% 1.02x
StackPromo 129595 128053 -1.2% 1.01x(?)
DictionarySwap 6118 6078 -0.7% 1.01x
StringInterpolation 15930 15822 -0.7% 1.01x(?)
ObserverClosure 7053 7008 -0.6% 1.01x(?)
AnyHashableWithAClass 80350 79635 -0.9% 1.01x(?)
Dictionary3 1383 1376 -0.5% 1.01x(?)
ObjectiveCBridgeToNSArray 30866 30596 -0.9% 1.01x(?)
ObjectiveCBridgeStubToNSDateRef 3371 3335 -1.1% 1.01x(?)
CaptureProp 100828 99982 -0.8% 1.01x(?)
AngryPhonebook 3009 2969 -1.3% 1.01x(?)
DictionaryRemoveOfObjects 48235 47979 -0.5% 1.01x(?)
ObjectiveCBridgeStubURLAppendPath 247783 245104 -1.1% 1.01x(?)
Dictionary 1862 1838 -1.3% 1.01x(?)
ObjectiveCBridgeToNSDictionary 61399 60711 -1.1% 1.01x(?)
StrToInt 5908 5826 -1.4% 1.01x
ObjectiveCBridgeStubNSDateMutationRef 14224 14057 -1.2% 1.01x(?)
Dictionary2OfObjects 6006 5939 -1.1% 1.01x
TwoSum 4847 4817 -0.6% 1.01x
ArraySubscript 5631 5624 -0.1% 1.00x(?)
ObjectiveCBridgeToNSString 1099 1097 -0.2% 1.00x
MonteCarloPi 53572 53695 +0.2% 1.00x
RecursiveOwnedParameter 10841 10870 +0.3% 1.00x(?)
Integrate 365 365 +0.0% 1.00x
ObjectiveCBridgeFromNSArrayAnyObjectToString 99128 98808 -0.3% 1.00x(?)
ClassArrayGetter 1276 1276 +0.0% 1.00x
Array2D 815706 814877 -0.1% 1.00x(?)
Histogram 9930 9890 -0.4% 1.00x(?)
SortStrings 2681 2677 -0.1% 1.00x
ReversedArray 45402 45343 -0.1% 1.00x(?)
DictionarySwapOfObjects 20056 20067 +0.1% 1.00x(?)
StringWithCString 152636 152712 +0.1% 1.00x(?)
Prims 12715 12766 +0.4% 1.00x(?)
SortLettersInPlace 2462 2459 -0.1% 1.00x(?)
ReversedDictionary 32112 32116 +0.0% 1.00x(?)
Dictionary3OfObjects 2137 2132 -0.2% 1.00x(?)
RangeAssignment 7172 7169 -0.0% 1.00x(?)
ByteSwap 9 9 +0.0% 1.00x
SuperChars 266496 265558 -0.3% 1.00x(?)
XorLoop 19995 19991 -0.0% 1.00x(?)
ObjectiveCBridgeStubToNSString 1327 1331 +0.3% 1.00x(?)
ArrayAppendStrings 11863 11873 +0.1% 1.00x(?)
StaticArray 11537 11575 +0.3% 1.00x(?)
SortSortedStrings 8472 8478 +0.1% 1.00x(?)
ObjectiveCBridgeFromNSSetAnyObject 85923 85735 -0.2% 1.00x(?)
Walsh 13277 13277 +0.0% 1.00x
Dictionary2 3646 3645 -0.0% 1.00x(?)
StrComplexWalk 7402 7379 -0.3% 1.00x
SetIntersect_OfObjects 11856 11902 +0.4% 1.00x(?)
Join 1478 1473 -0.3% 1.00x(?)
ArrayOfRef 8929 8950 +0.2% 1.00x(?)
ObserverUnappliedMethod 8756 8774 +0.2% 1.00x(?)
ObjectiveCBridgeToNSSet 38253 38353 +0.3% 1.00x(?)
NSError 672 675 +0.5% 1.00x(?)
DictionaryOfObjects 4618 4610 -0.2% 1.00x(?)
PopFrontUnsafePointer 178504 178840 +0.2% 1.00x
PolymorphicCalls 1145 1144 -0.1% 1.00x(?)
RC4 9385 9382 -0.0% 1.00x(?)
ObjectiveCBridgeStubToNSStringRef 155 155 +0.0% 1.00x
MapReduce 44785 44910 +0.3% 1.00x(?)
IterateData 10077 10072 -0.1% 1.00x(?)
DictionaryLiteral 15845 15860 +0.1% 1.00x(?)
Hanoi 19888 19817 -0.4% 1.00x(?)
UTF8Decode 45684 45837 +0.3% 1.00x(?)
SortStringsUnicode 9279 9238 -0.4% 1.00x
SetIsSubsetOf 1920 1916 -0.2% 1.00x
ObjectiveCBridgeFromNSArrayAnyObject 76933 77089 +0.2% 1.00x(?)
SetIntersect 11020 11068 +0.4% 1.00x
ObjectiveCBridgeStubDataAppend 3531 3540 +0.2% 1.00x(?)
SetExclusiveOr 20774 20758 -0.1% 1.00x(?)
NSDictionaryCastToSwift 6097 6114 +0.3% 1.00x(?)
ArrayInClass 3955 3957 +0.1% 1.00x(?)
Sim2DArray 14782 14774 -0.1% 1.00x(?)
SetExclusiveOr_OfObjects 39481 39652 +0.4% 1.00x(?)
MonteCarloE 108456 108129 -0.3% 1.00x(?)
SetUnion_OfObjects 28222 28306 +0.3% 1.00x
StringHasSuffixUnicode 64927 65157 +0.3% 1.00x(?)
HashTest 5267 5273 +0.1% 1.00x(?)
ArrayAppend 3551 3551 +0.0% 1.00x
DictionaryRemove 17709 17788 +0.5% 1.00x
LinkedList 27846 27869 +0.1% 1.00x(?)
RGBHistogramOfObjects 83620 83603 -0.0% 1.00x(?)
ObjectiveCBridgeFromNSSetAnyObjectForced 7575 7587 +0.2% 1.00x(?)
ArrayAppendReserved 3302 3303 +0.0% 1.00x(?)
SetUnion 11904 11941 +0.3% 1.00x(?)
ObserverForwarderStruct 5256 5248 -0.1% 1.00x(?)
DeadArray 121582 121691 +0.1% 1.00x(?)
ObjectiveCBridgeStubNSDataAppend 2794 2782 -0.4% 1.00x(?)
ArrayLiteral 1257 1262 +0.4% 1.00x(?)
ArrayValueProp3 3066 3064 -0.1% 1.00x(?)
ArrayValueProp 2621 2621 +0.0% 1.00x
GlobalClass 0 0 +0.0% 1.00x
Memset 20967 20959 -0.0% 1.00x(?)
ArrayValueProp4 3018 3005 -0.4% 1.00x(?)
ArrayValueProp2 3128 3136 +0.3% 1.00x
ObserverPartiallyAppliedMethod 8370 8376 +0.1% 1.00x(?)
PopFrontArray 13601 13685 +0.6% 0.99x(?)
ObjectiveCBridgeFromNSStringForced 3126 3154 +0.9% 0.99x(?)
ObjectiveCBridgeStubToNSDate 14179 14304 +0.9% 0.99x(?)
ErrorHandling 3773 3830 +1.5% 0.99x(?)
ReversedBidirectonal 130745 132236 +1.1% 0.99x(?)
ObjectAllocation 551 556 +0.9% 0.99x(?)
ProtocolDispatch2 441 444 +0.7% 0.99x
ObjectiveCBridgeStubURLAppendPathRef 248301 250493 +0.9% 0.99x(?)
ObjectiveCBridgeFromNSDictionaryAnyObjectToStringForced 112355 112939 +0.5% 0.99x(?)
ObjectiveCBridgeStubNSDateRefAccess 1257 1264 +0.6% 0.99x
StringBuilder 2761 2786 +0.9% 0.99x(?)
ArrayOfGenericRef 9933 9988 +0.6% 0.99x(?)
ObjectiveCBridgeFromNSString 4564 4622 +1.3% 0.99x(?)
SetIsSubsetOf_OfObjects 1880 1890 +0.5% 0.99x(?)
ObjectiveCBridgeFromNSSetAnyObjectToStringForced 87695 89016 +1.5% 0.99x(?)
RGBHistogram 34357 34628 +0.8% 0.99x(?)
ObjectiveCBridgeStubFromArrayOfNSString 58113 58756 +1.1% 0.99x(?)
SevenBoom 1502 1517 +1.0% 0.99x(?)
ObjectiveCBridgeFromNSDictionaryAnyObjectToString 189915 193989 +2.1% 0.98x(?)
ObjectiveCBridgeFromNSArrayAnyObjectForced 10776 10946 +1.6% 0.98x(?)
ArrayAppendLazyMap 259947 265772 +2.2% 0.98x
TypeFlood 184 188 +2.2% 0.98x(?)
PopFrontArrayGeneric 9411 9609 +2.1% 0.98x
OpenClose 398 407 +2.3% 0.98x(?)
ArrayAppendRepeatCol 211362 216659 +2.5% 0.98x(?)
ObjectiveCBridgeStubFromNSDate 3767 3834 +1.8% 0.98x
ObjectiveCBridgeFromNSDictionaryAnyObject 171764 176576 +2.8% 0.97x(?)
ArrayAppendGenericStructs 1345 1380 +2.6% 0.97x
ObjectiveCBridgeStubToArrayOfNSString 29109 30112 +3.5% 0.97x(?)
ObjectiveCBridgeStubDateAccess 1095 1125 +2.7% 0.97x
NSStringConversion 1348 1386 +2.8% 0.97x
ArrayOfPOD 1839 1899 +3.3% 0.97x
ObjectiveCBridgeFromNSArrayAnyObjectToStringForced 90984 93738 +3.0% 0.97x(?)
ObjectiveCBridgeFromNSDictionaryAnyObjectForced 8000 8310 +3.9% 0.96x(?)
ObjectiveCBridgeStubFromNSStringRef 158 165 +4.4% 0.96x
ObjectiveCBridgeFromNSSetAnyObjectToString 127056 132555 +4.3% 0.96x(?)
ArrayAppendOptionals 1307 1374 +5.1% 0.95x
**Hardware Overview** Model Name: Mac mini Model Identifier: Macmini7,1 Processor Name: Intel Core i5 Processor Speed: 2.8 GHz Number of Processors: 1 Total Number of Cores: 2 L2 Cache (per Core): 256 KB L3 Cache: 3 MB Memory: 16 GB

@swift-ci
Copy link
Contributor

swift-ci commented Jan 5, 2017

Build failed
Jenkins build - Swift Test OS X Platform
Git Commit - ca6353d
Test requested by - @airspeedswift

@shahmishal
Copy link
Member

@swift-ci Please clean test macOS

@airspeedswift airspeedswift mentioned this pull request Jan 6, 2017
Merged
@airspeedswift
Copy link
Member Author

Please test with following pull request:
swiftlang/swift-corelibs-foundation#760

@swift-ci Please test Linux platform

@swift-ci
Copy link
Contributor

swift-ci commented Jan 6, 2017

Build failed
Jenkins build - Swift Test Linux Platform
Git Commit - ca6353d
Test requested by - @airspeedswift

@shahmishal
Copy link
Member

Please test with following pull request:
swiftlang/swift-corelibs-foundation#760

@swift-ci Please test Linux platform

@airspeedswift
Copy link
Member Author

Please test with following pull request:
swiftlang/swift-corelibs-foundation#760

@swift-ci Please test Linux platform

@swift-ci
Copy link
Contributor

swift-ci commented Jan 7, 2017

Build failed
Jenkins build - Swift Test Linux Platform
Git Commit - ca6353d
Test requested by - @airspeedswift

@airspeedswift
Copy link
Member Author

@swift-ci Please test macOS platform

@swift-ci
Copy link
Contributor

swift-ci commented Jan 7, 2017

Build failed
Jenkins build - Swift Test OS X Platform
Git Commit - ca6353d
Test requested by - @airspeedswift

@airspeedswift airspeedswift merged commit 717e907 into swiftlang:master Jan 7, 2017
@airspeedswift airspeedswift mentioned this pull request Jan 8, 2017
Closed
@atrick
Copy link
Contributor

atrick commented Jan 10, 2017

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@airspeedswift @swift-ci @shahmishal @atrick @dabrahams