[IRGen] Cast dynamic alloca to appropriate type. #66014
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
slavapestov
reviewed
May 19, 2023
lib/IRGen/GenPack.cpp
Outdated
| @@ -454,6 +454,8 @@ irgen::emitTypeMetadataPack(IRGenFunction &IGF, | |||
| auto pack = IGF.emitDynamicAlloca(IGF.IGM.TypeMetadataPtrTy, shape, | |||
| IGF.IGM.getPointerAlignment(), | |||
| /*allowTaskAlloc=*/true); | |||
| pack = pack.withAddress(IGF.Builder.CreateElementBitCast( | |||
There was a problem hiding this comment.
Should we do this inside emitDynamicAlloca() or is it not worth refactoring since we're switching to opaque pointers at some point?
There was a problem hiding this comment.
Yeah, let's do that.
slavapestov
approved these changes
May 19, 2023
Fix the type of the `alloca` created by `GenPack`'s for type metadata and witness tables by fixing its callee, `emitDynamicAlloca` to always return a `StackAddress` whose `Address`' type is the one specified by the caller. rdar://109540863
nate-chandler
force-pushed
the
rdar109540863
branch
from
4b66e97 to
4b46622
Compare
|
@swift-ci please test |
nate-chandler
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the type of the
allocacreated byGenPackfor type metadata and witness tables by fixing its callee,emitDynamicAllocato always return aStackAddresswhoseAddress' type is the one specified by the caller.rdar://109540863