Skip to content

[5.9] Correctly print swift Int property as NSUInteger when it overrides an NSUInteger objc property. #66052

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 2, 2023
Merged

[5.9] Correctly print swift Int property as NSUInteger when it overrides an NSUInteger objc property. #66052

merged 1 commit into from
Jun 2, 2023

Conversation

allevato
Copy link
Member

  • Explanation: Clang rebranch started reporting certain types to be wrapped in ElaboratedType instead of the underlying TypedefType, which caused the logic to break for printing NSUInteger instead of NSInteger when a Swift Int method/property override an Obj-C decl that used NSUInteger.
  • Scope: Narrow; affects the Obj-C header generated for a Swift class that subclasses another Obj-C class
  • Risk: Low; this fixes a regression in the 5.9 branch after the rebranch
  • Reviewers: @egorzhdan
  • Issue: rdar://102629628
  • Original pull request: Correctly print swift Int property as NSUInteger when it overrides an NSUInteger objc property. #66011

@egorzhdan @allevato
Merge pull request swiftlang#66011 from thunderseethe/fix-print-objc-…
2a14d32 
…nsuint

Correctly print swift `Int` property as `NSUInteger` when it overrides an `NSUInteger` objc property.
@allevato allevato requested a review from egorzhdan May 22, 2023 14:45
@allevato allevato requested a review from a team as a code owner May 22, 2023 14:45
@allevato
Copy link
Member Author

@swift-ci please test

@allevato allevato requested a review from DougGregor May 24, 2023 16:38
@tbkka
Copy link
Contributor

tbkka commented Jun 2, 2023

CC: @beccadax

@tbkka tbkka merged commit 5b04be3 into swiftlang:release/5.9 Jun 2, 2023
@artemcm
Copy link
Contributor

artemcm commented Jun 2, 2023

Thank you @allevato !

@allevato allevato deleted the int-uint-override-5.9 branch June 6, 2023 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nkcsgexi nkcsgexi nkcsgexi approved these changes

@egorzhdan egorzhdan egorzhdan approved these changes

@tbkka tbkka tbkka approved these changes

@DougGregor DougGregor Awaiting requested review from DougGregor

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@allevato @tbkka @artemcm @nkcsgexi @egorzhdan