Skip to content

[5.9] [SymbolGraphGen] refactor protocol conformance inheritance checking #66054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 22, 2023
Merged

[5.9] [SymbolGraphGen] refactor protocol conformance inheritance checking #66054

merged 1 commit into from
May 22, 2023

Conversation

QuietMisdreavus
Copy link
Contributor

Cherry-pick of #66012

  • Explanation: This PR refactors protocol expansion in SymbolGraphGen to properly account for protocols that require inheritance from a specific class.
  • Scope: Fixes a crash when these protocol conformances were added via an extension.
  • Issue: rdar://109418762
  • Risk: Low. The change is functionally equivalent to the previous code, and does not affect normal compilation.
  • Testing: Tests were added to ensure that these kinds of protocol conformances no longer crash SymbolGraphGen.
  • Reviewer: @theMomax @slavapestov

@QuietMisdreavus QuietMisdreavus requested a review from a team as a code owner May 22, 2023 15:33
@QuietMisdreavus
Copy link
Contributor Author

@swift-ci Please test

@QuietMisdreavus QuietMisdreavus merged commit 6cdd8f7 into release/5.9 May 22, 2023
@QuietMisdreavus QuietMisdreavus deleted the QuietMisdreavus/5.9/proto-class-inheritance branch May 22, 2023 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DougGregor DougGregor DougGregor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@QuietMisdreavus @DougGregor