Skip to content

[5.9] Relax FileCheck directives for skip_clean_llbuild.test #66063

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

edymtt
Copy link
Contributor

@edymtt edymtt commented May 22, 2023

This is needed short term to allow the test to pass when running on Python 3.11 and later and avoid errors like

<stdin>:44:1: note: non-matching line after previous match is here
<string>:1: DeprecationWarning: 'pipes' is deprecated and slated for removal in Python 3.13
^

Long term we want to replace uses of the obsolete pipes.quotes function with shlex.quotes.

Addresses rdar://109664710

(cherry picked from commit 1534925,
#66062)

This is needed short term to allow the test to pass when running on
Python 3.11 and later and avoid errors like

```
<stdin>:44:1: note: non-matching line after previous match is here
<string>:1: DeprecationWarning: 'pipes' is deprecated and slated for removal in Python 3.13
^
```

Long term we want to replace uses of the obsolete `pipes.quotes`
function with `shlex.quotes`.

Addresses rdar://109664710

(cherry picked from commit 1534925,
 swiftlang#66062)
@edymtt edymtt requested a review from a team as a code owner May 22, 2023 19:14
@edymtt
Copy link
Contributor Author

edymtt commented May 22, 2023

@swift-ci please test

@edymtt
Copy link
Contributor Author

edymtt commented May 22, 2023

@swift-ci please test Apple Silicon

@edymtt
Copy link
Contributor Author

edymtt commented May 22, 2023

@swift-ci please build toolchain

@edymtt
Copy link
Contributor Author

edymtt commented May 23, 2023

On Apple Silicon skip_clean_llbuild is now passing, the only failure is unrelated to this PR

******************** TEST 'Swift(macosx-arm64) :: Python/python_lint.swift' FAILED ********************
Script:
--
: 'RUN: at line 8';   /Applications/Xcode.app/Contents/Developer/usr/bin/python3 /Users/ec2-user/jenkins/workspace/swift-pr-arm64-macos/branch-release/5.9/swift/utils/python_lint.py
--
Exit Code: 1

Command Output (stdout):
--

The flake8 and flake8-import-order Python packages are required for linting,
but these were not found on your system.

You can install these using:

    python3 -m pip install flake8
    python3 -m pip install flake8-import-order

For more help, see http://flake8.pycqa.org.


--
...
Failed Tests (1):
  Swift(macosx-arm64) :: Python/python_lint.swift

@edymtt
Copy link
Contributor Author

edymtt commented May 23, 2023

@swift-ci please test Apple Silicon

@edymtt
Copy link
Contributor Author

edymtt commented May 24, 2023

The Apple Silicon bot is failing testing llbuild, passing the critical point

...
PASS: Swift-validation(macosx-arm64) :: BuildSystem/skip_clean_llbuild.test (9147 of 16275)
...
Failed Tests (1):
  llbuild :: SwiftBuildTool/swift-compiler-whole-module-optimization.swift-build

@hamishknight
Copy link
Contributor

swiftlang/swift-llbuild#880

@swift-ci please test Apple Silicon

@shahmishal shahmishal merged commit 0bbd7b4 into swiftlang:release/5.9 May 30, 2023
@edymtt edymtt deleted the edymtt/relax-skip_clean_llbuild.test-5.9 branch May 31, 2023 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants