Skip to content

[benchmark] add removeAll(keepingCapacity: true) benchmark for non-unique arrays #66087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 24, 2023

Conversation

oxy
Copy link
Contributor

@oxy oxy commented May 23, 2023

Add a benchmark for the issue described by #56321 (rdar://71809690), so that the actual fix (#66085) can be measured.

@oxy
Copy link
Contributor Author

oxy commented May 23, 2023

@swift-ci please benchmark

@glessard
Copy link
Contributor

@swift-ci please benchmark

@oxy oxy requested a review from glessard May 23, 2023 19:47
@oxy
Copy link
Contributor Author

oxy commented May 23, 2023

@swift-ci please benchmark

Copy link
Contributor

@glessard glessard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for the benchmark!

@oxy
Copy link
Contributor Author

oxy commented May 24, 2023

@swift-ci please benchmark

@oxy oxy force-pushed the gh56321-benchmark branch from b6021c1 to 32745c3 Compare May 24, 2023 04:10
@oxy
Copy link
Contributor Author

oxy commented May 24, 2023

@swift-ci please benchmark

@oxy
Copy link
Contributor Author

oxy commented May 24, 2023

@swift-ci please smoke test and merge

@swift-ci swift-ci merged commit caa497a into swiftlang:main May 24, 2023
@glessard
Copy link
Contributor

glessard commented May 24, 2023

Output from the benchmark run about the new additions:

✅ Benchmark Check Report
unable to compute memory footprint of Array.removeAll.keepingCapacity.Int
unable to compute memory footprint of Array.removeAll.keepingCapacity.Object

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants