[Runtime] Skip metadata records search for classes in the __C module. #66109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ObjC classes won't be found, so don't spend lots of time searching for them. rdar://109783948
|
@swift-ci Please test |
al45tair
reviewed
May 25, 2023
| #if SWIFT_OBJC_INTEROP | ||
| // Classes in the __C module are ObjC classes. They never have a | ||
| // nominal type descriptor, so don't bother to search for one. | ||
| if (node && node->getKind() == Node::Kind::Class) |
There was a problem hiding this comment.
I might have used && a bit more and had fewer if statements, but this is fine.
There was a problem hiding this comment.
My thinking is that we want a separate binding for child to make the later conditions more comprehensible, and the check for "does this node have a module name at all?" is conceptually different from "does the module name match the thing we're looking for?" But ultimately the (dis)organization of the code just matches that of the brain it came from.
al45tair
approved these changes
May 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ObjC classes won't be found, so don't spend lots of time searching for them.
rdar://109783948