[AST] don't break a doc comment with a regular comment #66136
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves rdar://95307936
When a declaration has a regular comment between its doc comment and the declaration itself, that doc comment is lost:
This PR changes the comment attachment rules to skip over ordinary comments instead of using them to break them apart like a blank line would.
Notably, this change surfaced a bug in the standard library documentation: The default implementation of the
!=
operator in Equatable had a regular comment between the doc comment and the declaration, causing that documentation to be lost. (This is why i had to update the tests intest/SourceKit/DocSupport
, because the documentation for!=
started showing up!)