[5.9] Emit updated debug info when inout parameters are consumed and reinitialized. #66143
+62
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ialized. Change SILGen to emit the `debug_value` instruction using the original inout parameter address, instead of the `mark_must_check` inserted for move-only parameters, because code in the MoveOnlyAddressChecker did not expect to find the debug_value anywhere but on the original address. Update move-only diagnostics so that they pick up the declaration name for a memory location from any debug_value instruction if there are more than one. rdar://109740281
|
@swift-ci Please test |
1 similar comment
|
@swift-ci Please test |
tbkka
approved these changes
May 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
––– CCC Information –––
• Issue: rdar://109740281
• Explanation: Makes
inoutparameters get debug info updates when consumed and reinitialized, like local variables.• Scope of Issue:
inoutparameter values would appear to be initialized in the debugger when invalid.• Origination: Noncopyable types support.
• Risk: Low. Improves debug info for new code using noncopyable types, but should have no effect on existing code that doesn't use noncopyable types.
• Reviewed By: @gottesmm
• Automated Testing: Swift CI
• Dependencies: None
• Builder Impact: Not applicable
• Directions for QE: None