Fix a crash during lookup of an operator with package acl #66155
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci smoke test |
Type-checking an operator requires look up of all of its decls regardless of which access modifier is used before filtering. If one of them is a package decl in an imported module that was built with package-name, but the use site of the operator decl is in a module that is not built with package-name, it currently crashes as it tries to access package context of the use site, which is null. This PR checks if both decl site and use site have package contexts before accessing the package name property, otherwise return false to be filtered out. Resolves rdar://108961906
|
@swift-ci smoke test |
elsh
changed the title
tshortli
approved these changes
May 26, 2023
xedin
approved these changes
May 26, 2023
xymus
reviewed
May 26, 2023
elsh
added a commit
that referenced
this pull request
May 30, 2023
[5.9] Fix a crash during lookup of an operator with package acl Description: Type-checking an operator requires look up of all of its decls regardless of which access modifier is used before filtering. If one of them is a package decl in an imported module that was built with package-name, but the use site of the operator decl is in a module that is not built with package-name, it currently crashes as it tries to access package context of the use site, which is null. The change in this PR checks if both decl site and use site have package contexts before accessing the package name property, otherwise return false to be filtered out. This PR also includes a check of source file kind before showing diagnostics to ensure that errors are not shown if source is interface as interface does not include package symbols. Risk: Low. It adds a null check on package context before accessing package name. Original PR: Fix a crash during lookup of an operator with package acl #66155 Reviewed By: @tshortli @xedin @xymus Testing: Added a test that ensures coverage of the affected flow Resolves: rdar://108961906
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type-checking an operator requires look up of all of its decls regardless of
which access modifier is used before filtering. If one of them is a package
decl in an imported module that was built with package-name, but the use site
of the operator decl is in a module that is not built with package-name, it
currently crashes as it tries to access package context of the use site, which
is null. This PR checks if both decl site and use site have package contexts
before accessing the package name property, otherwise return false to be
filtered out.
Resolves rdar://108961906