Skip to content

[Distributed] Relax ordering of checks in async_taskgroup_discarding_dontLeak #66166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 26, 2023
Merged

[Distributed] Relax ordering of checks in async_taskgroup_discarding_dontLeak #66166

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 20 additions & 20 deletions test/Concurrency/Runtime/async_taskgroup_discarding_dontLeak.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,8 +67,8 @@ final class SomeClass: @unchecked Sendable {
SomeClass(id: "race-boom-class") // will be discarded
}
// since values may deinit in any order, we just assert their count basically
// CHECK: deinit, id: race-boom-class
// CHECK: deinit, id: race-boom-class
// CHECK-DAG: deinit, id: race-boom-class
// CHECK-DAG: deinit, id: race-boom-class

return 12
}
Expand All @@ -80,12 +80,12 @@ final class SomeClass: @unchecked Sendable {
SomeClass(id: "many-ok") // will be discarded
}
// since values may deinit in any order, we just assert their count basically
// CHECK: deinit, id: many-ok
// CHECK: deinit, id: many-ok
// CHECK: deinit, id: many-ok
// CHECK: deinit, id: many-ok
// CHECK: deinit, id: many-ok
// CHECK: deinit, id: many-ok
// CHECK-DAG: deinit, id: many-ok
// CHECK-DAG: deinit, id: many-ok
// CHECK-DAG: deinit, id: many-ok
// CHECK-DAG: deinit, id: many-ok
// CHECK-DAG: deinit, id: many-ok
// CHECK-DAG: deinit, id: many-ok
}

return 12
Expand All @@ -101,12 +101,12 @@ final class SomeClass: @unchecked Sendable {
}

// since values may deinit in any order, we just assert their count basically
// CHECK: deinit, id: many-error
// CHECK: deinit, id: many-error
// CHECK: deinit, id: many-error
// CHECK: deinit, id: many-error
// CHECK: deinit, id: many-error
// CHECK: deinit, id: many-error
// CHECK-DAG: deinit, id: many-error
// CHECK-DAG: deinit, id: many-error
// CHECK-DAG: deinit, id: many-error
// CHECK-DAG: deinit, id: many-error
// CHECK-DAG: deinit, id: many-error
// CHECK-DAG: deinit, id: many-error

12 // must be ignored
}
Expand Down Expand Up @@ -138,13 +138,13 @@ final class SomeClass: @unchecked Sendable {

// since values may deinit in any order, we just assert their count basically
// three ok's
// CHECK: deinit, id: mixed
// CHECK: deinit, id: mixed
// CHECK: deinit, id: mixed
// CHECK-DAG: deinit, id: mixed
// CHECK-DAG: deinit, id: mixed
// CHECK-DAG: deinit, id: mixed
// three errors
// CHECK: deinit, id: mixed
// CHECK: deinit, id: mixed
// CHECK: deinit, id: mixed
// CHECK-DAG: deinit, id: mixed
// CHECK-DAG: deinit, id: mixed
// CHECK-DAG: deinit, id: mixed

return 12
}
Expand Down