[5.9][ConstraintSystem] Some more variadic generic fixes #66173
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 8f4ad8b)
… without type parameter packs If function type of some declaration has a at least on type parameter pack it could mean that number of parameters in "applied" type could be different from that of "interface" type. (cherry picked from commit 70e4cf0)
…ty matches
This covers situations like `Pack{repeat each T1, repeat each T2}`
vs. `Pack{repeat $T1, repeat $T2}` where type variables are allowed
to bind to packs.
Resolves: rdar://109539394
(cherry picked from commit 1e03cdc)
…on patterns (cherry picked from commit fe6cfe2)
…h is okay in some cases (cherry picked from commit 7c91107)
|
@swift-ci please test |
hborla
approved these changes
May 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation:
getFunctionArgApplyInfoto types without type parameter packsScope: Expressions with value pack expansions.
Main Branch PR: [ConstraintSystem] Some more variadic generic fixes #66080
Risk: Very Low
Reviewed By: @hborla
Testing: Added regression test-cases to the suite.
Resolves: rdar://109539394