Implement checking for missing consume-on-all-paths of self in discard-ing contexts.
#66190
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kavon
force-pushed
the
discard-checking
branch
3 times, most recently
from
b92e77a to
f6d3cb2
Compare
|
@swift-ci please smoke test |
kavon
force-pushed
the
discard-checking
branch
2 times, most recently
from
d39e50d to
78c3c3b
Compare
As part of SE-390, you're required to write either: - `consume self` - pass self as a `consuming` parameter to a function - `discard self` before the function ends in a context that contains a `discard self` somewhere. This prevents people from accidentally invoking the deinit due to implicit destruction of `self` before exiting the function. rdar://106099027
|
@swift-ci smoke test and merge |
kavon
changed the title
self in discard-ing contexts.self in discard-ing contexts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of SE-390, you're required to write either:
consume selfconsumingparameter to a functiondiscard selfbefore the function ends in a context that contains a
discard selfsomewhere. This prevents people from accidentallyinvoking the deinit due to implicit destruction of
selfbeforeexiting the function.
rdar://106099027