[Sema] Increase impact of ternary then branch aiming better diagnostics #66208
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LucianoPAlmeida
requested review from
hborla,
slavapestov and
xedin
as code owners
|
@swift-ci Please smoke test |
xedin
reviewed
May 30, 2023
xedin
approved these changes
May 30, 2023
LucianoPAlmeida
force-pushed
the
diag-ternary
branch
from
0f3f949 to
fef908e
Compare
|
@swift-ci Please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another small diagnostic quality one.
In this scenario, solution which recorded the argument mismatch on the result of ternary which is the correct fix to apply in that case was being considered worst than the then branch contextual mismatch leading to misleading diagnostics. To me it does make sense to have the ternary branch slightly worst to avoid this sort of things, but let me know what you think.
Resolves #66192