[Variadic Generics] drop requirement of .element for tuple expansion #66214
+94
−29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sophiapoirier
requested review from
hborla,
xedin,
slavapestov and
tshortli
as code owners
|
@swift-ci please smoke test |
xedin
approved these changes
May 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The solution in the PR is not in its final form. This version synthesizes
.elementaccess on the abstract tuple in the constraint system. The next step is to move away from depending on.elementin any form, but I decided to commit the work in this stage to unblock the design proposal review and to stanch the bleeding in the form of this work getting seriously broken every couple of days by other changes in the codebase (which has been significant since I began it).addresses rdar://107160966