[5.9] Print package-name in .private.swiftinterface only for better abstraction #66256
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nterface only as package symbols are not contained in public swiftinterface and the clients of the swiftinterface should not be privy to the package-name input value. The change has already landed in main; this PR is to enforce the same behavior on 5.9. Risk: Low. The change has been on main already and been tested. Original PR: #65336 Reivewers: @xymus Testing: Added tests to ensure the flag is abstracted away from public swiftinterface Resolves: rdar://107638447
|
@swift-ci test |
elsh
changed the title
|
cherrypicked from main #65336 |
xymus
approved these changes
Jun 1, 2023
nkcsgexi
approved these changes
Jun 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: package-name flag needs to be printed in .private.swiftinterface
only as package symbols are not contained in public swiftinterface and the
clients of the swiftinterface should not be privy to the package-name input
value. The change has already landed in main; this PR is to enforce the same
behavior on 5.9.
Risk: Low. The change has been on main already and been tested.
Original PR: #65336
Reivewers: @xymus
Testing: Added tests to ensure the flag is abstracted away from public swiftinterface
Resolves: rdar://107638447