Member lookup macro expansion performance #66257
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When performing name lookup into a type (and its extensions), we may need to expand macros. While we are careful to expand macros that we don't need to expand, we were still looping over all of the extensions of a type (and all of the members of those extensions!) looking for places where macros could have been used. In an example with 6,000 extensions of the same type, generated like this:
The checking for potential macro expansions regressed type checker performance by more than 25%, and adding on more extensions compounded the problem nonlinearly.
Introduce mechanisms to ensure that we only check what kinds of macro expansions each extension introduces once, capturing all of the potential macro-introduced names and caching it via the evaluator. Then, keep a list of only the extensions that can produce macro expansions and loop over that---not the whole list of extensions---when we need to check whether a given name might be produced by macros. This returns the example's type-checking time back to what it was
Fixes rdar://109543968, eliminating the regression.