🍒[cxx-interop] Do not treat std::pair<UnsafeType, T> as safe
#66284
+35
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdar://109529750 (cherry picked from commit f277158)
|
@swift-ci please test |
DougGregor
approved these changes
Jun 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation: If a C++ types has a copy constructor, we assume that it is safe to use from Swift. Unfortunately this means that types such as
std::pair<UnsafeType, T>are treated as safe. This is a larger issue that needs to be addressed, but for now let's make sure we handlestd::pairandstd::tuplecorrectly: treat them as safe only if their templated parameters are safe.Scope: This changes the way Swift imports C++ methods that return
std::pair<A, B>where either A or B is unsafe in Swift.Risk: Low, this only takes effect when C++ interop is enabled.
rdar://109529750
(cherry picked from commit f277158)