Skip to content

Add a test for extension of a public type conforming to SPI protocol #66291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 2, 2023
Merged

Add a test for extension of a public type conforming to SPI protocol #66291

merged 1 commit into from
Jun 2, 2023

Conversation

elsh
Copy link
Contributor

@elsh elsh commented Jun 2, 2023

This PR verifies that an extension can conform to an SPI protocol from another module if attributed with SPI.
Ref rdar://63470756

@elsh elsh requested a review from xymus June 2, 2023 00:04
@elsh
Copy link
Contributor Author

elsh commented Jun 2, 2023

@swift-ci smoke test

xymus
xymus approved these changes Jun 2, 2023
View reviewed changes
Copy link
Contributor

@xymus xymus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@elsh elsh merged commit 4fd67b2 into main Jun 2, 2023
@elsh elsh deleted the es-rdar56 branch June 2, 2023 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xymus xymus xymus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@elsh @xymus