Skip to content

PackElementType changes, part 2 #66294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jun 2, 2023

Conversation

slavapestov
Copy link
Contributor

This is still all NFC for now. Getting quite large so I'm splitting it off.

…itutionMap)

It's fine to have the empty generic signature and non-empty
substitution map here. Also, correctly handle an input
generic signature with non-canonical generic parameter types.
This can't happen yet, but with an upcoming change, we hit an infinite
recursion here with PackExpansionType::get() -> getReducedShape()
-> mapTypeIntoContext() -> PackExpansionType::get().
@slavapestov
Copy link
Contributor Author

@swift-ci Please smoke test

@slavapestov slavapestov merged commit fd81f81 into swiftlang:main Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant