[Runtime] Don't cache malloc_default_zone. #66305
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test and merge |
|
@swift-ci please test macos platform |
|
I like this! |
yln
approved these changes
Jun 6, 2023
stdlib/public/runtime/Heap.cpp
Outdated
| } else { | ||
| size_t alignment = computeAlignment(alignMask); | ||
| p = malloc_type_zone_memalign(DEFAULT_ZONE(), alignment, size, typeId); | ||
| malloc_type_memalign(&p, alignment, size, typeId); |
There was a problem hiding this comment.
Nit: use malloc_type_aligned_alloc to avoid memalign's awkward interface (out parameter) and the need to initialize p (which makes it different from the original swift_slowAlloc function above).
There was a problem hiding this comment.
Oh nice, I was looking for “memalign” specifically and missed that.
Caching the default zone should no longer be necessary. rdar://102870625
mikeash
force-pushed
the
dont-cache-malloc-default-zone
branch
from
3c0dec3 to
007ac9a
Compare
|
@swift-ci please smoke test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Caching the default zone should no longer be necessary.
rdar://102870625