Skip to content

Disable TempRValueOpt when there are users of the temp object preceding the copy #66328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 5, 2023
Merged

Disable TempRValueOpt when there are users of the temp object preceding the copy #66328

merged 1 commit into from
Jun 5, 2023

Conversation

meg-gupta
Copy link
Contributor

rdar://108361427

@meg-gupta meg-gupta requested a review from eeckstein June 5, 2023 05:55
@meg-gupta
Copy link
Contributor Author

@swift-ci test

@meg-gupta meg-gupta requested review from atrick and nate-chandler June 5, 2023 05:59
@meg-gupta
Copy link
Contributor Author

@swift-ci test

@meg-gupta
Copy link
Contributor Author

@swift-ci smoke test

atrick
atrick approved these changes Jun 5, 2023
View reviewed changes
Copy link
Contributor

@atrick atrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I got a little hung up trying to figure out how you can assume that projections are in the copy block. So it might be nice to comment that we assume collectLoads will enforce that. It could be in a different PR.

nate-chandler
nate-chandler approved these changes Jun 5, 2023
View reviewed changes
Copy link
Contributor

@nate-chandler nate-chandler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@meg-gupta
Copy link
Contributor Author

@swift-ci smoke test and merge

@meg-gupta meg-gupta mentioned this pull request Jun 5, 2023
Merged
@swift-ci swift-ci merged commit 1d39add into swiftlang:main Jun 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atrick atrick atrick approved these changes

@nate-chandler nate-chandler nate-chandler approved these changes

@eeckstein eeckstein Awaiting requested review from eeckstein eeckstein is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@meg-gupta @atrick @nate-chandler @swift-ci