-
Notifications
You must be signed in to change notification settings - Fork 10.5k
[Backtracing][Linux] Enable Linux backtracing, add tests. #66338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
e0d9649
[Backtracing][IRGen] Add a semantic attribute to force frame pointer.
al45tair 43ed01f
[Backtracing][Linux] Reorganise modules for _Backtracing.
al45tair 438ab7f
[Backtracing][Linux] Add Linux support to the _Backtracing module.
al45tair 6ad9720
[Backtracing][Linux] Temporarily add a default addressWidth.
al45tair 8d91384
[Backtracing][Linux] Work correctly in the presence of partial reads.
al45tair 582946b
[Backtracing][Linux] Remove status argument.
al45tair 1262518
[Backtracing][Linux] Add a comment about __cxa_demangle.
al45tair d4b8828
[Backtracing][Linux] Also remove the status argument from Runtime mod…
al45tair a890ec2
[Backtracing][Linux][Tests] Fix verify_all_overlays test.
al45tair a9ce1cd
[Backtracing][Linux] Add Linux support to swift-backtrace.
al45tair 8cf570c
Revert "[Backtracing][Linux] Temporarily add a default addressWidth."
al45tair df8e698
[Backtracing][Linux] Remove some stray "public" annotations.
al45tair ee55964
[Backtracing][Linux] Enable Linux backtracing, add tests.
al45tair 3042cd7
[Backtracing][Linux] Enable backtrace-on-crash for Linux.
al45tair File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,50 @@ | ||
//===--- ArrayImageSource.swift - An image source backed by an Array -------===// | ||
// | ||
// This source file is part of the Swift.org open source project | ||
// | ||
// Copyright (c) 2023 Apple Inc. and the Swift project authors | ||
// Licensed under Apache License v2.0 with Runtime Library Exception | ||
// | ||
// See https://swift.org/LICENSE.txt for license information | ||
// See https://swift.org/CONTRIBUTORS.txt for the list of Swift project authors | ||
// | ||
//===----------------------------------------------------------------------===// | ||
// | ||
// Defines ArrayImageSource, an image source that is backed by a Swift Array. | ||
// | ||
//===----------------------------------------------------------------------===// | ||
|
||
import Swift | ||
|
||
@_implementationOnly import OS.Libc | ||
|
||
enum ArrayImageSourceError: Error { | ||
case outOfBoundsRead(UInt64, UInt64) | ||
} | ||
|
||
struct ArrayImageSource<T>: ImageSource { | ||
private var array: Array<T> | ||
|
||
public init(array: Array<T>) { | ||
self.array = array | ||
} | ||
|
||
public var isMappedImage: Bool { return false } | ||
public var path: String? { return nil } | ||
public var bounds: Bounds? { | ||
return Bounds(base: 0, size: Size(array.count * MemoryLayout<T>.stride)) | ||
} | ||
|
||
public func fetch<U>(from addr: Address, | ||
into buffer: UnsafeMutableBufferPointer<U>) throws { | ||
try array.withUnsafeBytes{ | ||
let size = Size($0.count) | ||
let requested = Size(buffer.count * MemoryLayout<U>.stride) | ||
if addr > size || requested > size - addr { | ||
throw ArrayImageSourceError.outOfBoundsRead(addr, requested) | ||
} | ||
|
||
memcpy(buffer.baseAddress!, $0.baseAddress! + Int(addr), Int(requested)) | ||
} | ||
} | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wasn't aware of this module, do we finally have a replacement for all the numerous platform-specific libc modules?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No. The
_Backtracing
module has its own thing that does precisely that, but it isn't available outside of the build oflibswift_Backtracing
. Why do that? Because we actually can't useGlibc
,Darwin
et al from here for build system related reasons, so the alternative was a horrible header inSwiftShims
that had to redeclare all kinds of things from each of the C libraries. That made me very sad, so instead I turned off implicit modules and added amodules
directory in theBacktracing
directory that contains a handful of special modules that are only used by_Backtracing
, only with the C/C++ importer, and only ever@_implementationOnly
at that.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is relevant here because of 1c8362b, which was needed because I did that (and because the test does slightly the wrong thing — it treats the module it's testing as the main module, which causes the deserialiser to behave differently).