Skip to content

[5.9][Serialization] Fix serializing CompilerPluginExecutablePaths values #66370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 7, 2023

Conversation

xymus
Copy link
Contributor

@xymus xymus commented Jun 6, 2023

Fix a typo making us lose the search paths for executable macros in swiftmodule files. That information is used by LLDB to apply macros in the expression evaluator.

Risk: Low, the modified data is consumed only by LLDB.
Cherry-pick of: #66309
Resolves: rdar://110068048

@xymus xymus added 🍒 release cherry pick Flag: Release branch cherry picks swift 5.9 labels Jun 6, 2023
@xymus xymus requested review from rintaro and adrian-prantl June 6, 2023 16:37
@xymus xymus requested a review from a team as a code owner June 6, 2023 16:37
@xymus xymus requested a review from nkcsgexi June 6, 2023 16:37
@xymus
Copy link
Contributor Author

xymus commented Jun 6, 2023

@swift-ci Please test

@xymus
Copy link
Contributor Author

xymus commented Jun 6, 2023

The macOS test is failing on the build configuration issue. Let's try again.

@swift-ci Please test macOS

@xymus
Copy link
Contributor Author

xymus commented Jun 6, 2023

@swift-ci Please test macOS

@xymus xymus merged commit cf7b7c7 into swiftlang:release/5.9 Jun 7, 2023
@xymus xymus deleted the fix-serial-macros-5.9 branch June 7, 2023 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🍒 release cherry pick Flag: Release branch cherry picks swift 5.9
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants