[Backtracing] Make StackOverflow test less sensitive. #66433
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Depending on the platform, architecture and stack layout, we may or may not have line numbers for the very first frame. rdar://110418951
|
@swift-ci Please test |
|
Explanation: The StackOverflow backtracing test needs to be more relaxed about the first line in the backtrace. Depending on exactly where the PC is when the stack actually overflows (which is architecture and platform specific), we may be in a place where we don't have line numbers (e.g. the function prologue). This was causing the test to fail on UBI9-aarch64 builds. |
|
Given that this is a test-only change, merging without branch manager approval to fix the bots. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depending on the platform, architecture and stack layout, we may or may not have line numbers for the very first frame.
rdar://110418951