[5.9] SILGen: Don't copy a borrowed noncopyable address-only base of a computed property access. #66475
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uted property access. We can probably avoid this copy in more circumstances, but make the change only for noncopyable types for now, since that's the case where it's most semantically apparent. rdar://109161396
|
@swift-ci Please test |
tbkka
approved these changes
Jun 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: rdar://109161396
• Explanation: Accessing a computed property on an "address-only" noncopyable type would crash the compiler and/or raise a spurious "borrowed value cannot be consumed" error trying to consume the base.
• Scope of Issue: Fixes a compiler crash and reject-valid bug.
• Origination: Noncopyable types feature work.
• Risk: Low. The fix targets a specific code pattern only when using noncopyable types, for code that currently crashes the compiler. Potential miscompiles ought to be diagnosed by the move-only checker, so that they do not lead to accidentally successful compiles.
• Reviewed By: @gottesmm
• Automated Testing: Swift CI
• Dependencies: None
• Builder Impact: Not applicable
• Directions for QE: None