Requestify AbstractStorageDecl::hasStorage().
#66482
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DougGregor
requested review from
slavapestov,
hborla,
xedin and
CodaFi
as code owners
|
@swift-ci please smoke test |
DougGregor
force-pushed
the
requestify-has-storage
branch
from
245a3d5 to
5be151e
Compare
|
@swift-ci please smoke test |
|
@swift-ci please test source compatibility |
DougGregor
force-pushed
the
requestify-has-storage
branch
from
5be151e to
655f35c
Compare
|
@swift-ci please clean smoke test |
The `hasStorage()` computation is used in many places to determine the signatures of other declarations. It currently needs to expand accessor macros, which causes a number of cyclic references. Provide a simplified request to determine `hasStorage` without expanding or resolving macros, breaking a common pattern of cycles when using macros. Fixes rdar://109668383.
… impl info Slightly cleanup, and make an assertion less strict in the face of invalid code.
Now that we've made accessor macro expansion more lazy, ensure that when querying for init accessors (e.g., to build a memberwise initializer), we also expand any accessor macros that might produce an init accessor. This is a partial step toward the real goal, which is that `AbstractStorageDecl::getAccessor()` should lazily expand macros if needed. Update the Observable macro to document that it produces an `init` accessor.
Remove an early iteration of cycle-breaking in `PatternBindingEntryRequest` that has been subsumed by the lazy computation of `AbstractStorageDecl::hasStorage()`. We can now directly use `hasStorage()` here.
DougGregor
force-pushed
the
requestify-has-storage
branch
from
655f35c to
5457290
Compare
|
@swift-ci please smoke test |
Matejkob
reviewed
May 13, 2024
| #if OBSERVATION_SUPPORTS_PEER_MACROS | ||
| @attached(peer, names: prefixed(_)) | ||
| #endif | ||
| public macro ObservationTracked() = | ||
| #externalMacro(module: "ObservationMacros", type: "ObservationTrackedMacro") | ||
|
|
||
| @available(SwiftStdlib 5.9, *) | ||
| @attached(accessor) | ||
| @attached(accessor, names: named(willSet)) |
There was a problem hiding this comment.
Hi everyone,
I was reviewing this old PR and came across the names: named(willSet) argument. I don't get why this has been added. Does anyone recall the specific reason for adding this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
hasStorage()computation is used in many places to determine the signatures of other declarations. It currently needs to expand accessor macros, which causes a number of cyclic references. Provide a simplified request to determinehasStoragewithout expanding or resolving macros, breaking a common pattern of cycles when using macros.Fixes rdar://109668383.