Skip to content

Add a benchmark for += in ArrayAppend #6653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 12, 2017
Merged

Add a benchmark for += in ArrayAppend #6653

merged 1 commit into from
Jan 12, 2017

Conversation

ben-ng
Copy link

@ben-ng ben-ng commented Jan 8, 2017

Adds a benchmark for the Array += operator, so we can measure the impact of #6652.

@airspeedswift
Copy link
Member

@swift-ci Please smoke test

@airspeedswift
Copy link
Member

@swift-ci please benchmark

@airspeedswift
Copy link
Member

The benchmark job will fail because the comparison can't handle when benchmarks have been added (unless that's been fixed) but you can see from the log if the benchmark itself runs fine but then the comparison failed.

@airspeedswift
Copy link
Member

oh oops except you also need to wire the benchmark up here: https://github.com/apple/swift/blob/master/benchmark/utils/main.swift#L124

@ben-ng ben-ng force-pushed the bng-array-append-benchmark branch from b5953d1 to 6cbf5c6 Compare January 8, 2017 05:31
@ben-ng
Copy link
Author

ben-ng commented Jan 8, 2017

D'oh, I was expecting some sort of magic to happen.

@ben-ng ben-ng mentioned this pull request Jan 8, 2017
Closed
@swift-ci
Copy link
Contributor

swift-ci commented Jan 8, 2017

Build comment file:

Optimized (O)

Regression (0)
Improvement (1)
TEST OLD_MIN NEW_MIN DELTA (%) SPEEDUP
PopFrontArray 1295 1144 -11.7% 1.13x(?)
No Changes (154)
TEST OLD_MIN NEW_MIN DELTA (%) SPEEDUP
ObjectiveCBridgeFromNSDictionaryAnyObjectToString 173752 170504 -1.9% 1.02x(?)
Join 471 462 -1.9% 1.02x(?)
StaticArray 130 128 -1.5% 1.02x(?)
ObjectiveCBridgeStubNSDateMutationRef 12207 11926 -2.3% 1.02x(?)
StringHasSuffix 700 689 -1.6% 1.02x(?)
DictionaryBridge 3403 3374 -0.8% 1.01x(?)
StringInterpolation 11182 11052 -1.2% 1.01x(?)
Dictionary2 2030 2005 -1.2% 1.01x(?)
ObjectiveCBridgeStubURLAppendPathRef 231671 229875 -0.8% 1.01x(?)
ObjectiveCBridgeStubToNSDateRef 3282 3262 -0.6% 1.01x(?)
Dictionary2OfObjects 3429 3408 -0.6% 1.01x(?)
ArraySubscript 1445 1439 -0.4% 1.00x(?)
ObjectiveCBridgeToNSString 1071 1073 +0.2% 1.00x(?)
StackPromo 21385 21449 +0.3% 1.00x(?)
ObjectiveCBridgeFromNSDictionaryAnyObject 163396 163999 +0.4% 1.00x(?)
RecursiveOwnedParameter 1938 1940 +0.1% 1.00x(?)
Integrate 238 238 +0.0% 1.00x
ObjectiveCBridgeFromNSArrayAnyObjectToString 96456 96844 +0.4% 1.00x(?)
ClassArrayGetter 12 12 +0.0% 1.00x
Array2D 2029 2039 +0.5% 1.00x(?)
Histogram 286 286 +0.0% 1.00x
SortStrings 1651 1653 +0.1% 1.00x(?)
ObjectiveCBridgeFromNSDictionaryAnyObjectForced 5487 5499 +0.2% 1.00x(?)
ObjectiveCBridgeStubFromNSDateRef 3963 3960 -0.1% 1.00x(?)
MonteCarloPi 45156 44993 -0.4% 1.00x
StringWithCString 198734 198884 +0.1% 1.00x(?)
ObjectiveCBridgeFromNSArrayAnyObjectForced 6204 6220 +0.3% 1.00x(?)
ObjectiveCBridgeFromNSStringForced 2704 2705 +0.0% 1.00x(?)
Prims 730 730 +0.0% 1.00x
SortLettersInPlace 1044 1043 -0.1% 1.00x(?)
DictionarySwap 427 427 +0.0% 1.00x
ReversedDictionary 99 99 +0.0% 1.00x
ArrayAppendToFromGeneric 599 599 +0.0% 1.00x
ArrayOfGenericPOD 220 220 +0.0% 1.00x
Dictionary3OfObjects 872 870 -0.2% 1.00x(?)
RangeAssignment 286 285 -0.3% 1.00x(?)
StringHasPrefix 608 608 +0.0% 1.00x
ByteSwap 0 0 +0.0% 1.00x
SuperChars 213497 214381 +0.4% 1.00x(?)
ArrayAppendLazyMap 915 914 -0.1% 1.00x(?)
ObjectiveCBridgeStubToNSDate 13024 13088 +0.5% 1.00x(?)
XorLoop 380 380 +0.0% 1.00x
ObserverClosure 1965 1962 -0.1% 1.00x(?)
ObjectiveCBridgeStubToNSString 1283 1282 -0.1% 1.00x(?)
ArrayAppendStrings 12142 12125 -0.1% 1.00x(?)
ObjectiveCBridgeStubFromNSStringRef 125 125 +0.0% 1.00x
ObjectiveCBridgeStubFromNSString 772 772 +0.0% 1.00x
ProtocolDispatch 3040 3039 -0.0% 1.00x(?)
TypeFlood 0 0 +0.0% 1.00x
SortSortedStrings 838 837 -0.1% 1.00x(?)
StringHasSuffixUnicode 63553 63583 +0.1% 1.00x(?)
ObjectiveCBridgeFromNSSetAnyObject 80909 80699 -0.3% 1.00x(?)
ArrayLiteral 1177 1175 -0.2% 1.00x(?)
Walsh 324 324 +0.0% 1.00x
Dictionary3 522 522 +0.0% 1.00x
StrComplexWalk 2906 2915 +0.3% 1.00x(?)
SetIntersect_OfObjects 1492 1493 +0.1% 1.00x(?)
ErrorHandling 2942 2949 +0.2% 1.00x(?)
ArrayOfRef 3542 3542 +0.0% 1.00x
ObserverUnappliedMethod 2350 2341 -0.4% 1.00x(?)
ObjectiveCBridgeToNSSet 38194 38016 -0.5% 1.00x(?)
ArrayPlusEqualArrayOfInt 599 599 +0.0% 1.00x
NSError 326 326 +0.0% 1.00x
DictionaryOfObjects 2272 2275 +0.1% 1.00x(?)
PopFrontArrayGeneric 1143 1143 +0.0% 1.00x
PopFrontUnsafePointer 9151 9154 +0.0% 1.00x(?)
StringEqualPointerComparison 7306 7303 -0.0% 1.00x(?)
CaptureProp 4562 4565 +0.1% 1.00x(?)
PolymorphicCalls 22 22 +0.0% 1.00x
ArrayAppendReserved 536 536 +0.0% 1.00x
ObjectiveCBridgeStubToNSStringRef 116 116 +0.0% 1.00x
Calculator 36 36 +0.0% 1.00x
ArrayAppendFromGeneric 599 599 +0.0% 1.00x
MapReduce 342 343 +0.3% 1.00x(?)
ObjectiveCBridgeStubDateMutation 273 273 +0.0% 1.00x
AngryPhonebook 2823 2828 +0.2% 1.00x(?)
IterateData 2605 2603 -0.1% 1.00x(?)
DictionaryLiteral 1266 1265 -0.1% 1.00x(?)
Hanoi 3450 3452 +0.1% 1.00x(?)
OpenClose 54 54 +0.0% 1.00x
DictionaryRemoveOfObjects 19296 19271 -0.1% 1.00x(?)
UTF8Decode 288 288 +0.0% 1.00x
SortStringsUnicode 7251 7273 +0.3% 1.00x(?)
LinkedList 7210 7211 +0.0% 1.00x(?)
ObjectiveCBridgeFromNSDictionaryAnyObjectToStringForced 107553 107866 +0.3% 1.00x(?)
SetIsSubsetOf 250 250 +0.0% 1.00x
Dictionary 719 720 +0.1% 1.00x(?)
NopDeinit 21445 21448 +0.0% 1.00x(?)
ObjectiveCBridgeFromNSArrayAnyObject 74682 74311 -0.5% 1.00x(?)
SetIntersect 360 361 +0.3% 1.00x(?)
ObjectiveCBridgeStubDataAppend 3423 3418 -0.1% 1.00x(?)
SetExclusiveOr 2574 2571 -0.1% 1.00x(?)
NSDictionaryCastToSwift 4953 4951 -0.0% 1.00x(?)
ObjectiveCBridgeFromNSSetAnyObjectToString 117237 116912 -0.3% 1.00x(?)
ArrayAppendOptionals 1234 1234 +0.0% 1.00x
ArrayInClass 63 63 +0.0% 1.00x
ArrayOfGenericRef 3670 3662 -0.2% 1.00x(?)
ObjectiveCBridgeFromNSString 1799 1799 +0.0% 1.00x
Phonebook 7536 7537 +0.0% 1.00x(?)
ObjectiveCBridgeStubDateAccess 182 182 +0.0% 1.00x
Sim2DArray 277 277 +0.0% 1.00x
SetExclusiveOr_OfObjects 7452 7454 +0.0% 1.00x(?)
ArrayAppendRepeatCol 759 758 -0.1% 1.00x(?)
ObjectiveCBridgeToNSDictionary 61309 61574 +0.4% 1.00x(?)
MonteCarloE 10576 10582 +0.1% 1.00x(?)
SetUnion_OfObjects 6252 6258 +0.1% 1.00x(?)
ReversedBidirectional 44900 44943 +0.1% 1.00x(?)
GlobalClass 0 0 +0.0% 1.00x
ArrayAppendToGeneric 599 599 +0.0% 1.00x
HashTest 1750 1750 +0.0% 1.00x
SetIsSubsetOf_OfObjects 307 307 +0.0% 1.00x
ArrayAppend 774 775 +0.1% 1.00x(?)
DictionaryRemove 2276 2281 +0.2% 1.00x(?)
StringHasPrefixUnicode 14151 14169 +0.1% 1.00x(?)
ObjectiveCBridgeFromNSSetAnyObjectToStringForced 81882 81944 +0.1% 1.00x(?)
RGBHistogramOfObjects 21488 21558 +0.3% 1.00x(?)
NSStringConversion 795 792 -0.4% 1.00x(?)
RGBHistogram 2299 2297 -0.1% 1.00x(?)
ObjectiveCBridgeFromNSSetAnyObjectForced 4726 4719 -0.1% 1.00x(?)
ArrayAppendSequence 1391 1393 +0.1% 1.00x(?)
ArrayAppendArrayOfInt 599 599 +0.0% 1.00x
ArrayOfPOD 182 182 +0.0% 1.00x
SetUnion 2439 2436 -0.1% 1.00x(?)
Chars 613 613 +0.0% 1.00x
ReversedArray 49 49 +0.0% 1.00x
StringBuilder 1319 1316 -0.2% 1.00x(?)
ObserverForwarderStruct 897 896 -0.1% 1.00x(?)
ObjectiveCBridgeStubNSDateRefAccess 338 338 +0.0% 1.00x
DeadArray 185 185 +0.0% 1.00x
ObjectiveCBridgeStubNSDataAppend 2465 2471 +0.2% 1.00x(?)
BitCount 1 1 +0.0% 1.00x
SevenBoom 1346 1347 +0.1% 1.00x(?)
ObjectiveCBridgeFromNSArrayAnyObjectToStringForced 89536 89797 +0.3% 1.00x(?)
StringWalk 5899 5896 -0.1% 1.00x(?)
ArrayValueProp 6 6 +0.0% 1.00x
ObjectiveCBridgeStubFromArrayOfNSString 57499 57730 +0.4% 1.00x(?)
Memset 235 235 +0.0% 1.00x
ArrayValueProp4 6 6 +0.0% 1.00x
TwoSum 1320 1320 +0.0% 1.00x
ArrayValueProp2 6 6 +0.0% 1.00x
ArrayValueProp3 6 6 +0.0% 1.00x
ObjectiveCBridgeStubFromNSDate 4040 4044 +0.1% 1.00x(?)
ObserverPartiallyAppliedMethod 3352 3345 -0.2% 1.00x(?)
DictionarySwapOfObjects 6192 6251 +0.9% 0.99x(?)
ArrayAppendGenericStructs 1234 1241 +0.6% 0.99x(?)
ObjectAllocation 153 154 +0.7% 0.99x(?)
ProtocolDispatch2 158 160 +1.3% 0.99x(?)
ObjectiveCBridgeToNSArray 30297 30548 +0.8% 0.99x(?)
ObjectiveCBridgeStubURLAppendPath 229838 231251 +0.6% 0.99x(?)
ObjectiveCBridgeStubToArrayOfNSString 29650 29896 +0.8% 0.99x(?)
AnyHashableWithAClass 64543 64939 +0.6% 0.99x(?)
RC4 165 166 +0.6% 0.99x
154 2920651 2968250 +1.6% 0.98x
StrToInt 5244 5441 +3.8% 0.96x
**Unoptimized (Onone)**
Regression (0)
Improvement (0)
No Changes (155)
TEST OLD_MIN NEW_MIN DELTA (%) SPEEDUP
ArrayAppendGenericStructs 1419 1362 -4.0% 1.04x(?)
ObjectiveCBridgeFromNSSetAnyObjectToString 127630 125277 -1.8% 1.02x(?)
DictionaryBridge 3501 3470 -0.9% 1.01x(?)
ObjectiveCBridgeStubToNSDate 14492 14335 -1.1% 1.01x(?)
AnyHashableWithAClass 81115 79935 -1.4% 1.01x(?)
ArrayAppendOptionals 1377 1361 -1.2% 1.01x(?)
ObjectiveCBridgeStubToArrayOfNSString 30588 30229 -1.2% 1.01x(?)
SetIntersect 11195 11068 -1.1% 1.01x(?)
ObjectiveCBridgeToNSDictionary 62423 61810 -1.0% 1.01x(?)
ObjectiveCBridgeStubFromArrayOfNSString 59237 58693 -0.9% 1.01x(?)
ArraySubscript 5647 5633 -0.2% 1.00x(?)
ObjectiveCBridgeToNSString 1102 1106 +0.4% 1.00x(?)
DictionarySwapOfObjects 19918 19980 +0.3% 1.00x(?)
StackPromo 127064 127654 +0.5% 1.00x(?)
RecursiveOwnedParameter 10965 10948 -0.2% 1.00x(?)
Integrate 385 384 -0.3% 1.00x(?)
ObjectiveCBridgeFromNSArrayAnyObjectToString 98257 98138 -0.1% 1.00x(?)
ClassArrayGetter 1275 1276 +0.1% 1.00x(?)
Array2D 823521 823591 +0.0% 1.00x(?)
Histogram 9885 9879 -0.1% 1.00x(?)
SortStrings 2540 2547 +0.3% 1.00x(?)
ObjectiveCBridgeFromNSDictionaryAnyObjectForced 7949 7941 -0.1% 1.00x(?)
ObjectiveCBridgeStubFromNSDateRef 4067 4068 +0.0% 1.00x(?)
MonteCarloPi 53604 53682 +0.1% 1.00x(?)
StringWithCString 152949 153082 +0.1% 1.00x(?)
ObjectiveCBridgeFromNSStringForced 3149 3153 +0.1% 1.00x(?)
Prims 12851 12827 -0.2% 1.00x(?)
SortLettersInPlace 2686 2687 +0.0% 1.00x(?)
DictionarySwap 6135 6132 -0.1% 1.00x(?)
ReversedDictionary 33170 33118 -0.2% 1.00x(?)
ObjectiveCBridgeFromNSString 4648 4647 -0.0% 1.00x(?)
ArrayAppendToFromGeneric 716 716 +0.0% 1.00x
ArrayOfGenericPOD 3425 3423 -0.1% 1.00x(?)
Dictionary3OfObjects 2130 2131 +0.1% 1.00x(?)
RangeAssignment 7200 7174 -0.4% 1.00x(?)
StringHasPrefix 1554 1554 +0.0% 1.00x
ByteSwap 9 9 +0.0% 1.00x
SuperChars 266673 267130 +0.2% 1.00x(?)
ArrayAppendLazyMap 263776 263342 -0.2% 1.00x(?)
XorLoop 20660 20668 +0.0% 1.00x(?)
StringInterpolation 15950 15912 -0.2% 1.00x(?)
ObserverClosure 7059 7078 +0.3% 1.00x(?)
ObjectiveCBridgeStubToNSString 1339 1337 -0.1% 1.00x(?)
ArrayAppendStrings 11830 11849 +0.2% 1.00x(?)
ObjectiveCBridgeStubFromNSStringRef 156 156 +0.0% 1.00x
StaticArray 3786 3773 -0.3% 1.00x(?)
ProtocolDispatch 6085 6108 +0.4% 1.00x
ObjectAllocation 554 554 +0.0% 1.00x
SortSortedStrings 1253 1253 +0.0% 1.00x
ObjectiveCBridgeFromNSSetAnyObject 85690 85382 -0.4% 1.00x(?)
AngryPhonebook 3014 3026 +0.4% 1.00x(?)
ProtocolDispatch2 441 441 +0.0% 1.00x
Walsh 13222 13229 +0.1% 1.00x(?)
Dictionary3 1379 1374 -0.4% 1.00x(?)
Dictionary2 3668 3676 +0.2% 1.00x(?)
StrComplexWalk 8117 8129 +0.1% 1.00x(?)
SetIntersect_OfObjects 12083 12115 +0.3% 1.00x(?)
Join 1485 1486 +0.1% 1.00x(?)
ArrayOfRef 8953 8975 +0.2% 1.00x(?)
ObserverUnappliedMethod 8762 8774 +0.1% 1.00x(?)
ObjectiveCBridgeStubURLAppendPathRef 235900 235671 -0.1% 1.00x(?)
ObjectiveCBridgeToNSSet 38868 38882 +0.0% 1.00x(?)
ArrayPlusEqualArrayOfInt 716 716 +0.0% 1.00x
DictionaryOfObjects 4613 4613 +0.0% 1.00x
ObjectiveCBridgeStubToNSDateRef 3359 3349 -0.3% 1.00x(?)
PopFrontUnsafePointer 162583 162407 -0.1% 1.00x(?)
StringEqualPointerComparison 9730 9728 -0.0% 1.00x(?)
CaptureProp 100005 99991 -0.0% 1.00x(?)
PolymorphicCalls 1152 1151 -0.1% 1.00x(?)
RC4 9393 9388 -0.1% 1.00x(?)
ObjectiveCBridgeStubToNSStringRef 155 155 +0.0% 1.00x
Calculator 979 978 -0.1% 1.00x(?)
ArrayAppendFromGeneric 720 720 +0.0% 1.00x
MapReduce 44787 44805 +0.0% 1.00x(?)
ObjectiveCBridgeStubDateMutation 434 434 +0.0% 1.00x
IterateData 10080 10074 -0.1% 1.00x(?)
DictionaryLiteral 15993 15924 -0.4% 1.00x(?)
Hanoi 19572 19552 -0.1% 1.00x(?)
OpenClose 461 463 +0.4% 1.00x(?)
DictionaryRemoveOfObjects 47982 48045 +0.1% 1.00x(?)
UTF8Decode 45811 45790 -0.1% 1.00x(?)
SortStringsUnicode 8154 8128 -0.3% 1.00x(?)
154 5776500 5791782 +0.3% 1.00x
ObjectiveCBridgeFromNSDictionaryAnyObjectToStringForced 113327 113814 +0.4% 1.00x(?)
SetIsSubsetOf 1952 1953 +0.1% 1.00x(?)
Dictionary 1896 1896 +0.0% 1.00x
NopDeinit 45101 45134 +0.1% 1.00x(?)
ObjectiveCBridgeFromNSArrayAnyObject 76871 76948 +0.1% 1.00x(?)
ObjectiveCBridgeStubDataAppend 3502 3485 -0.5% 1.00x(?)
SetExclusiveOr 20706 20690 -0.1% 1.00x(?)
RGBHistogramOfObjects 83244 83040 -0.2% 1.00x(?)
ObjectiveCBridgeStubNSDateRefAccess 1198 1196 -0.2% 1.00x(?)
ArrayOfGenericRef 9963 9951 -0.1% 1.00x(?)
StringHasSuffix 1557 1557 +0.0% 1.00x
Phonebook 20922 20906 -0.1% 1.00x(?)
ObjectiveCBridgeStubDateAccess 1095 1095 +0.0% 1.00x
Sim2DArray 16525 16515 -0.1% 1.00x(?)
SetExclusiveOr_OfObjects 39464 39468 +0.0% 1.00x(?)
ArrayAppendRepeatCol 214721 213782 -0.4% 1.00x(?)
MonteCarloE 108280 108268 -0.0% 1.00x(?)
SetUnion_OfObjects 28229 28215 -0.1% 1.00x(?)
ReversedBidirectional 130333 130921 +0.5% 1.00x(?)
StringHasSuffixUnicode 65002 64995 -0.0% 1.00x(?)
ArrayAppendToGeneric 721 721 +0.0% 1.00x
HashTest 5255 5249 -0.1% 1.00x(?)
SetIsSubsetOf_OfObjects 1932 1932 +0.0% 1.00x
ArrayAppend 3350 3335 -0.5% 1.00x(?)
DictionaryRemove 17818 17826 +0.0% 1.00x(?)
StringHasPrefixUnicode 15784 15750 -0.2% 1.00x(?)
LinkedList 27651 27575 -0.3% 1.00x(?)
NSStringConversion 1315 1314 -0.1% 1.00x(?)
RGBHistogram 34563 34627 +0.2% 1.00x(?)
ObjectiveCBridgeFromNSSetAnyObjectForced 7577 7549 -0.4% 1.00x(?)
ArrayAppendSequence 84212 84213 +0.0% 1.00x(?)
ArrayAppendArrayOfInt 715 715 +0.0% 1.00x
ArrayOfPOD 1839 1840 +0.1% 1.00x(?)
SetUnion 11947 11956 +0.1% 1.00x(?)
Chars 6742 6743 +0.0% 1.00x(?)
ReversedArray 556 556 +0.0% 1.00x
StrToInt 5712 5717 +0.1% 1.00x(?)
ObserverForwarderStruct 5298 5282 -0.3% 1.00x(?)
DeadArray 121359 120900 -0.4% 1.00x(?)
ArrayValueProp2 3143 3149 +0.2% 1.00x(?)
ArrayLiteral 1232 1230 -0.2% 1.00x(?)
SevenBoom 1514 1509 -0.3% 1.00x(?)
ArrayValueProp4 3008 3011 +0.1% 1.00x(?)
StringWalk 21590 21554 -0.2% 1.00x(?)
ArrayValueProp 2626 2629 +0.1% 1.00x(?)
ObjectiveCBridgeStubNSDateMutationRef 14372 14420 +0.3% 1.00x(?)
GlobalClass 0 0 +0.0% 1.00x
Memset 20951 20971 +0.1% 1.00x(?)
Dictionary2OfObjects 5975 5966 -0.1% 1.00x(?)
TwoSum 4815 4822 +0.1% 1.00x(?)
ArrayValueProp3 3053 3057 +0.1% 1.00x(?)
ObjectiveCBridgeStubFromNSDate 3879 3887 +0.2% 1.00x(?)
ObserverPartiallyAppliedMethod 8465 8440 -0.3% 1.00x(?)
PopFrontArray 13575 13656 +0.6% 0.99x(?)
ObjectiveCBridgeFromNSDictionaryAnyObjectToString 184393 185600 +0.7% 0.99x(?)
ObjectiveCBridgeFromNSArrayAnyObjectForced 10290 10422 +1.3% 0.99x(?)
ObjectiveCBridgeFromNSDictionaryAnyObject 171248 172111 +0.5% 0.99x(?)
ObjectiveCBridgeStubFromNSString 806 814 +1.0% 0.99x(?)
ObjectiveCBridgeToNSArray 30588 30988 +1.3% 0.99x(?)
PopFrontArrayGeneric 9488 9576 +0.9% 0.99x(?)
ObjectiveCBridgeStubURLAppendPath 232915 234450 +0.7% 0.99x(?)
StringBuilder 2702 2716 +0.5% 0.99x(?)
ObjectiveCBridgeFromNSSetAnyObjectToStringForced 88223 88824 +0.7% 0.99x(?)
BitCount 97 98 +1.0% 0.99x
ObjectiveCBridgeFromNSArrayAnyObjectToStringForced 90877 91350 +0.5% 0.99x(?)
ArrayAppendReserved 3085 3103 +0.6% 0.99x
ObjectiveCBridgeStubNSDataAppend 2766 2783 +0.6% 0.99x(?)
ErrorHandling 3729 3808 +2.1% 0.98x(?)
NSError 680 692 +1.8% 0.98x(?)
NSDictionaryCastToSwift 6102 6244 +2.3% 0.98x(?)
ArrayInClass 4146 4211 +1.6% 0.98x(?)
TypeFlood 179 188 +5.0% 0.95x(?)
**Hardware Overview** Model Name: Mac mini Model Identifier: Macmini7,1 Processor Name: Intel Core i5 Processor Speed: 2.8 GHz Number of Processors: 1 Total Number of Cores: 2 L2 Cache (per Core): 256 KB L3 Cache: 3 MB Memory: 16 GB

@jessesquires jessesquires mentioned this pull request Jan 8, 2017
Closed
@airspeedswift
Copy link
Member

@swift-ci please benchmark

@airspeedswift
Copy link
Member

@swift-ci Please smoke test

@airspeedswift
Copy link
Member

Looks like the smoke test is failing due to an earlier PR unrelated to this one. The benchmark test is running on CI but not getting reported in the list of checks.

@swift-ci
Copy link
Contributor

swift-ci commented Jan 8, 2017

Build comment file:

Optimized (O)

@airspeedswift
Copy link
Member

New benchmark ran OK so this is OK to merge, but it'll need rebasing after the revert of the bad test.

If the goal is to target append of multiple-element collections too, we should add another benchmark for that e.g. of a 5-element collection.

@slavapestov slavapestov self-assigned this Jan 12, 2017
@ben-ng ben-ng force-pushed the bng-array-append-benchmark branch from 66b90b2 to 3e718d3 Compare January 12, 2017 03:11
@ben-ng
Copy link
Author

ben-ng commented Jan 12, 2017

Squashed and rebased on master.

@airspeedswift
Copy link
Member

@swift-CIA please smoke test and merge

@airspeedswift
Copy link
Member

Gah dyac

@swift-ci please smoke test and merge

@gottesmm
Copy link
Contributor

@swift-ci please smoke test and merge

@gottesmm
Copy link
Contributor

There you go!

@swift-ci swift-ci merged commit 5caa4a4 into swiftlang:master Jan 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@slavapestov slavapestov

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ben-ng @airspeedswift @swift-ci @gottesmm @slavapestov