Skip to content

[5.9][Macros] Plugin search options group #66678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

rintaro
Copy link
Member

@rintaro rintaro commented Jun 15, 2023

Cherry-pick #66650 into release/5.9

  • Explanation: The compiler currently orders compiler plugin lookup by kind. Instead, we should respect the exact ordering of the various arguments (-external-plugin-path, -plugin-path, etc.) on the command line when performing lookups.
  • Scope: Macro plugin loading
  • Risk: Low-Mid, Since this changes the plugin searching mechanism, it might changes the current behavior depending on how clients specify the arguments. But we expect almost none existing clients will be affected.
  • Testing: Regression tests updated
  • Issue: rdar://110819182
  • Reviewer: Doug Gregor (@DougGregor), Ben Barham (@bnbarham)

'load-plugin-library', 'load-plugin-executable', '-plugin-path' and
'-external-plugin-path' should be searched in the order they are
specified in the arguments.

Previously, for example '-plugin-path' used to precede
'-external-plugin-path' regardless of the position in the arguments.

(cherry picked from commit 5791a2c)
@rintaro rintaro requested a review from a team as a code owner June 15, 2023 18:41
@rintaro
Copy link
Member Author

rintaro commented Jun 15, 2023

swiftlang/llvm-project#6999
@swift-ci Please test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants