Add RISCV as llvm target to build #66699
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
finagolfin
approved these changes
Jun 19, 2023
|
@swift-ci please test |
|
@shahmishal can you run the CI tests please? |
|
@swift-ci please test |
|
@swift-ci please smoke test macOS |
|
The macOS test failure was spurious; kicking off another round |
|
@swift-ci please test macOS |
shahmishal
approved these changes
Jul 3, 2023
|
Difficuilt if im working in the field |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test Environment
OS = Ubuntu
Release = 22.04 / Jammy
When trying to build swift on a riscv64 linux system the following error occurs -
error: unable to create target: 'No available targets are compatible with triple "riscv64-unknown-linux-gnu"Resolves https://github.com/swift-riscv/swift-riscv64/issues/2
Updates and fixes the issues with #61891
@gottesmm , on #61891 you requested testing of how much extra build time adding RISCV will add to a clean build.
I have run several test builds at https://ci.swiftlang.xyz/job/swift-main-ubuntu-jammy/
There does not seem to be any noticeable increase build time. All build times are between 1h 4min and 1h 12min.