ModuleLoader: minor clean-up to remove dead code. NFC #66719
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test |
tshortli
reviewed
Jun 16, 2023
| ctx.SearchPathOpts.getSDKPath(), | ||
| "System", "Library", "Frameworks"); | ||
| if (isInSystemFrameworks(modulePath)) { | ||
| if (isInSystemFrameworks(modulePath, true)) { |
There was a problem hiding this comment.
Suggested change
| if (isInSystemFrameworks(modulePath, true)) { | |
| if (isInSystemFrameworks(modulePath, /*publicFramework=*/true)) { |
Alternatively, you could use an enum to make this value clearer at the call site.
nkcsgexi
force-pushed
the
clean-up-framework
branch
from
fe6b6b2 to
f4d8761
Compare
|
@swift-ci please smoke test |
tshortli
approved these changes
Jun 16, 2023
|
@swift-ci Please clean test Linux platform |
|
@swift-ci Please test Windows platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.