Refactor swift::findPointerEscape and handle additional cases #66723
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
Now that store_borrows are represented correctly, remove this hack.
…Escape(BorrowedValue)
meg-gupta
force-pushed
the
improvefindpointerescape
branch
from
f3082db to
860aa58
Compare
|
@swift-ci test |
meg-gupta
force-pushed
the
improvefindpointerescape
branch
from
860aa58 to
6d3b4e0
Compare
|
@swift-ci test |
|
@swift-ci test macOS platform |
nate-chandler
added a commit
to nate-chandler/swift
that referenced
this pull request
Jul 6, 2023
The two implementations of findPointerEscape were merged back in swiftlang#66723, so delete the declaration.
nate-chandler
added a commit
to nate-chandler/swift
that referenced
this pull request
Jul 7, 2023
The two implementations of findPointerEscape were merged back in swiftlang#66723, so delete the declaration.
atrick
reviewed
Jul 7, 2023
| // | ||
| // TODO: store_borrow is currently an InteriorPointer with no uses, so we end | ||
| // up bailing. It should be in a dependence scope instead. It's not clear why | ||
| // it produces an address at all. |
There was a problem hiding this comment.
We can remove the TODO comment now, but shouldn't we still report a dead projection as either a PointerEscape or Unknown? Otherwise, clients will need to separately look for and handle any possible dead projections. I don't think clients can currently handle that. Dead projections are unexpected but still legal SIL.
| @@ -56,6 +56,13 @@ bool swift::findPointerEscape(SILValue original) { | |||
| worklist.pushIfNotVisited(phi); | |||
| break; | |||
| } | |||
| case OperandOwnership::Borrow: { | |||
| auto borrowOp = BorrowingOperand(use); | |||
| if (auto borrowValue = borrowOp.getBorrowIntroducingUserResult()) { | |||
There was a problem hiding this comment.
Can a yielded or captured value escape? I think we talked about this being illegal because it crosses a function boundary. But the implementation here doesn't explain why we're ignoring these cases. We should at least explain that it was intentional.
nate-chandler
added a commit
to nate-chandler/swift
that referenced
this pull request
Jul 11, 2023
The two implementations of findPointerEscape were merged back in swiftlang#66723, so delete the declaration.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.