[CS] Avoid crashing if we have no contextual type for initialization #66762
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For `CTP_Initialization`, there's no contextual type to record if the pattern is not a `TypedPattern`. As such, tweak `RequirementFailure::getDeclRef` to handle this case. We probably ought to reconsider how we handle contextual types here, using a ContextualType locator when there is no contextual type recorded seems a bit weird, though in most cases we want to treat initializations the same regardless of if a TypedPattern was used. For now I'm leaving that as future work. rdar://111009224
|
@swift-ci please test |
xedin
approved these changes
Jun 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For
CTP_Initialization, there's no contextual type to record if the pattern is not aTypedPattern. As such, tweakRequirementFailure::getDeclRefto handle this case.We probably ought to reconsider how we handle contextual types here, using a ContextualType locator when there is no contextual type recorded seems a bit weird, though in most cases we want to treat initializations the same regardless of if a TypedPattern was used. For now I'm leaving that as future work.
rdar://111009224
Resolves #66752