[cxx-interop] Allow inserting elements into std::set from Swift
#66764
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
egorzhdan
requested review from
zoecarver,
hyp,
hborla,
slavapestov and
xedin
as code owners
|
@swift-ci please smoke test |
`std::set::insert` isn't exposed into Swift, because it returns an instance of an unsafe type. This change adds a Swift overload of `insert` for `std::set` and `std::unordered_set` that has the return type identical to `Swift.Set.insert`: a tuple of `(inserted: Bool, memberAfterInsert: Element)`. rdar://111036912
egorzhdan
force-pushed
the
egorzhdan/cxx-set-insert
branch
from
3c71015 to
b79b65c
Compare
|
@swift-ci please smoke test |
zoecarver
reviewed
Jun 20, 2023
| public mutating func insert( | ||
| _ element: Element | ||
| ) -> (inserted: Bool, memberAfterInsert: Element) { | ||
| let insertionResult = self.__insertUnsafe(element) |
There was a problem hiding this comment.
Worried this could be destroyed before L68 when it's accessed.
There was a problem hiding this comment.
insertionResult is a std::pair<iterator, bool>. The iterator itself won't be destroyed since we store it in let rawIterator. It would be safe if insertionResult is destroyed before L68.
zoecarver
approved these changes
Jun 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
std::set::insertisn't exposed into Swift, because it returns an instance of an unsafe type.This change adds a Swift overload of
insertforstd::setandstd::unordered_setthat has the return type identical toSwift.Set.insert: a tuple of(inserted: Bool, memberAfterInsert: Element).rdar://111036912