Skip to content

[AST] Add Builtin.packLength #66768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 11, 2023
Merged

[AST] Add Builtin.packLength #66768

merged 1 commit into from
Sep 11, 2023

Conversation

Azoy
Copy link
Contributor

@Azoy Azoy commented Jun 20, 2023

Add a new builtin which takes a pack expansion and counts the number of items within it. This is built on top of #66638.

@Azoy Azoy requested a review from slavapestov June 20, 2023 16:32
@Azoy Azoy requested review from hborla and xedin as code owners June 20, 2023 16:32
Copy link
Contributor

@slavapestov slavapestov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! Just a few minor nitpicks.

@Azoy
Copy link
Contributor Author

Azoy commented Jun 20, 2023

@swift-ci please test

@xedin xedin removed their request for review June 23, 2023 00:03
@Azoy Azoy force-pushed the pack-count-builtin branch from 8458e3e to 5fd7bc7 Compare September 7, 2023 16:59
@Azoy
Copy link
Contributor Author

Azoy commented Sep 7, 2023

@swift-ci please test

Simplify packCount IRGen

Emit pack_length instruction

Add space
@Azoy Azoy force-pushed the pack-count-builtin branch from 5fd7bc7 to ff6bd36 Compare September 7, 2023 22:36
@Azoy Azoy changed the title [IRGen] Add Builtin.packCount [AST] Add Builtin.packLength Sep 7, 2023
@Azoy
Copy link
Contributor Author

Azoy commented Sep 7, 2023

@swift-ci please test

@Azoy Azoy merged commit 93c332b into swiftlang:main Sep 11, 2023
@Azoy Azoy deleted the pack-count-builtin branch September 11, 2023 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants