[5.9] DefiniteInitialization: Error when noncopyable types are conditionally initialized. #66770
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y initialized. This leads to unhandled complications in the move-only checker that were causing miscompiles. We can disallow this for now. rdar://109695770
|
@swift-ci Please test |
DougGregor
approved these changes
Jun 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: rdar://109695770
• Explanation: Introduces an error when noncopyable values are initialized in some code paths but not others. We handle this for copyable types by introducing dynamic flags to track when the value is initialized in order to know when to destroy it. However, borrow checking relies on static analysis and is incompatible in its current form with this dynamic checking, so we will disallow it for now.
• Scope of Issue: Disables unsupported code patterns.
• Origination: New feature work.
• Risk: low -- introduces a diagnostic for the new noncopyable types feature disallowing unsupported code.
• Reviewed By: @xedin and @gottesmm
• Automated Testing: Swift CI
• Dependencies: None
• Builder Impact: Not applicable
• Directions for QE: None