Skip to content

SILCombine: correctly set the [stack] flag when replacing alloc_ref_dynamic with alloc_ref #66800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 21, 2023

Conversation

eeckstein
Copy link
Contributor

@eeckstein eeckstein commented Jun 21, 2023

Fixes a verifier crash.

Fixes #66312

@eeckstein eeckstein requested a review from nate-chandler June 21, 2023 09:51
…f_dynamic` with `alloc_ref`

Fixes a verifier crash.

swiftlang#66312
@eeckstein eeckstein force-pushed the fix-allocref-combine branch from 04c6ff7 to 26832c8 Compare June 21, 2023 09:52
@eeckstein
Copy link
Contributor Author

@swift-ci test

Copy link
Contributor

@nate-chandler nate-chandler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@eeckstein
Copy link
Contributor Author

@swift-ci smoke test macos

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SIL verification failure when evaluating $0 in certain closures.
2 participants