Sink address projections in ArrayPropertyOpt and enable verification to ensure we have no address phis #66825
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test Linux Platform |
1 similar comment
|
@swift-ci test Linux Platform |
|
@swift-ci test Windows Platform |
|
@swift-ci test source compatibility |
|
@swift-ci test macOS platform |
meg-gupta
force-pushed
the
addressphilast
branch
from
4657a58 to
1e89ad6
Compare
|
@swift-ci test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ArrayPropertyOpt is the last pass left that generates address phis. Sink address projections by cloning to avoid address phis. Turn on verification to ensure there are no address phis in non-OSSA SIL as well.