🍒[5.9][Distributed] Don't diagnose declared dist member properties when importing module #66842
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…orting module rdar://111080052
|
@swift-ci please test |
DougGregor
approved these changes
Jun 22, 2023
|
I'm going to merge this so it doesn't miss tagging but I'm working on adding a test confirming this in the test suite as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: We previously fixed that this method should not diagnose when checking in SourceFileKind::Interface mode, but we also should skip when there is no source file at all. This fixes compilation of the distributed cluster in 5.9, since the behavior of typechecking seems to have changed slightly and we didn't enter this function in such situations previously.
Risk: Low, prevents over-zelous error diagnostics messages when importing modules
Review by: @DougGregor
Testing: CI testing; Verified the cluster compiles again after the fix manually
Original PR: #66841
Radar: rdar://111080052