[5.9🍒] emit error when a noncopyable enum has a raw type #66847
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
previously I was allowing these because I thought there was some representational difference if the enum is raw. it turns out that a raw enum is only useful if you synthesize conformance to RawRepresentable. since I disabled that synthesis it's kind of silly to still allow the raw type to be written at all. rdar://110539937 (cherry picked from commit 79332c1)
|
@swift-ci please test |
DougGregor
approved these changes
Jun 22, 2023
|
@swift-ci please test windows platform |
1 similar comment
|
@swift-ci please test windows platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
• Description: A raw enum is only useful if you synthesize conformance to RawRepresentable. Since I disabled that synthesis for noncopyable enums, it's simply confusing for people to be able to declare a raw noncopyable enum.
• Risk: Low. Introduces a minor source break to prevent confusion.
• Original PR: #66818
• Reviewed By: @slavapestov
• Testing: regression tests included
• Resolves: rdar://110539937