Caching/CAS option improvements #66887
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cachemeifyoucan
requested review from
artemcm,
tshortli,
zoecarver,
hyp,
egorzhdan,
hborla,
slavapestov and
xedin
as code owners
|
@swift-ci please smoke test |
benlangmuir
reviewed
Jun 23, 2023
cachemeifyoucan
force-pushed
the
eng/PR-cas-option-updates
branch
from
645cbc3 to
c5d08d5
Compare
|
@swift-ci Please clean smoke test |
cachemeifyoucan
force-pushed
the
eng/PR-cas-option-updates
branch
from
c5d08d5 to
d73b13b
Compare
|
@swift-ci Please clean smoke test |
artemcm
approved these changes
Jun 23, 2023
benlangmuir
approved these changes
Jun 23, 2023
Using the same CASOption from clang to communicate CAS configurations so it is easier to exchange CAS configuration between them.
When the CASOptions are the same, SwiftDependencyScanningService can be shared with multiple swift driver invocation for scanning.
Rename `-enable-cas` to `-compile-cache-job` to align with clang option names and promote that to a new driver only flag. Few other additions to driver flag for caching behaviors: * `-compile-cache-remarks`: now cache hit/miss remarks are guarded behind this flag * `-compile-cache-skip`: skip replaying from the cache. Useful as a debugging tool to do the compilation using CAS inputs even the output is a hit from the cache.
cachemeifyoucan
force-pushed
the
eng/PR-cas-option-updates
branch
from
d73b13b to
284eb2a
Compare
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update CAS/Caching options and form proper driver options.