[5.9] Fix missing indexing data with overloaded type #66898
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When you have a type that's ambiguous because it's defined in 2 imported modules, but you don't have to disambiguate by using the module name, previously no index references were produced. Now most are for the common case, but notably nested type constructors and generics still aren't emitted, partially because of swiftlang#65726 Fixes: swiftlang#64598 (cherry picked from commit e9ff334 / swiftlang#65729)
|
@swift-ci please test |
|
cc @DougGregor 🙏🏻 |
|
I’m so sorry, we’ve been trying to narrow down what we’ve been accepting to regressions / crashes / finalizing new features, and this didn’t feel like it met that bar for the initial 5.9. I’d like us to keep the PR open in case we can pick it up in a dot release |
DougGregor
approved these changes
Aug 18, 2023
|
@swift-ci please test |
keith
deleted the
ks/5.9-fix-missing-indexing-data-with-overloaded-type
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you have a type that's ambiguous because it's defined in 2 imported modules, but you don't have to disambiguate by using the module name, previously no index references were produced. Now most are for the common case, but notably nested type constructors and generics still aren't emitted, partially because of #65726
Fixes: #64598
(cherry picked from commit e9ff334 / #65729)