[5.9] [stdlib] Add support for classes in _createOffsetBasedKeyPath #66932
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[stdlib] Add support for classes in _createOffsetBasedKeyPath
|
@swift-ci please test |
stephentyrone
approved these changes
Jun 26, 2023
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
• Explanation: This adds support for classes to be used in this SPI as well as adding the offset optimization for struct type key paths.
• Scope of Issue: Fixes a bug when using this API with class root types.
• Origination: Reflection work.
• Risk: Low -- New underscored API who isn't inlined who is only being used by reflection.
• Reviewed By: @stephentyrone
• Automated Testing: Swift CI
• Dependencies: None
• Builder Impact: Not applicable
• Directions for QE: None
Resolves: rdar://110547963