[5.9🍒] Be more specific than "noncopyable type T can't be used with generics yet" #66946
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…as used with. This change causes explicit types written in the source language that substitute a noncopyable type for a type variable in a generic type to state that's what's wrong. For example: ``` // NEW: noncopyable type 'MO' cannot be used with generic type 'Dictionary<Key, Value>' yet // OLD: noncopyable type 'MO' cannot be used with generics yet let _: [MO : T] ```
|
@swift-ci please test |
slavapestov
approved these changes
Jun 27, 2023
tbkka
approved these changes
Jun 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
• Description: Important polish work to be more helpful about the reason why a noncopyable can't be used, example:
• Risk: Very Low. Only changes the diagnostics to be more useful. When encountering a case it doesn't know how to handle, we fall back on the old, vague message.
• Original PR: #66871
• Reviewed By: @slavapestov
• Testing: regression tests included
• Resolves: rdar://108914588