[5.9] Fix Sendable checking for overrides, witnesses, and calls that involving sub typing or implicit conversions #66948
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he past, both the results and parameters of overriding (resp. conforming) functions were checked for Sendability. This is overly restrictive. For safety, the parameters of the overridden (resp. requiring) function should be checked for Sendability and the results of the overriding (resp. conforming) should be checked. This commit implements that change. (cherry picked from commit eb78da2)
Isolation checking for calls had two separate implementation places: one that looked at the declaration being called (for member declarations) and one that worked on the actual call expression. Unify on the latter implementation, which is more general and has access to the specific call arguments. Improve diagnostics here somewher so we don't regress in that area. This refactoring shouldn't change the actual semantics, but it makes upcoming semantic changes easier. (cherry picked from commit d78a5ed)
The move to perform all call checking that can cross concurrency domains into one place dropped the specific logic for distributed actor calls. Introduce that logic, cleaning it up to consistently use the "known to be local" semantics needed for distributed actors. (cherry picked from commit 740cd7b)
…te path Remove the "old" path that diagnosed actor isolation and sendability issues with some calls. It is now unused. (cherry picked from commit 11dd80a)
…in a call When checking for the sendability in a call, use the sendability of the original argument expressions rather than the parameter type, looking through any implicit conversions that might remove `Sendable`. Fixes rdar://110763694 / FB12343467. (cherry picked from commit 7c45c7d)
|
@swift-ci please test |
ktoso
approved these changes
Jun 27, 2023
hborla
approved these changes
Jun 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sendableconformances with the "wrong" end of a sub typing relationship or implicit conversion, causing spuriousSendable-related diagnostics. Overriding and witnesses need to check the overridden method or protocol requirement's parameters forSendable, not the overriding method and witness. For function calls, we need to look at the argument expression before any implicit conversions are applied, so that we diagnose sendability based on the argument itself---not the parameter it's initializing.